Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 64411002: project: Allow configuration of the project and task states

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by pokoli
Modified:
2 weeks, 6 days ago
Reviewers:
dave, reviewbot, ced, albert
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update to tip and set sequence on work_state_list #

Total comments: 26

Patch Set 3 : Fix comments #

Patch Set 4 : Set progress based on state and add missing not null migration #

Total comments: 5

Patch Set 5 : remove unused function, check total_progress and some wording imporvements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -75 lines) Patch
M CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M __init__.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/test_project.py View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
M view/work_form.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M view/work_list.xml View 1 chunk +1 line, -1 line 0 comments Download
M view/work_list_children.xml View 1 chunk +1 line, -1 line 0 comments Download
M view/work_list_simple.xml View 1 chunk +1 line, -1 line 0 comments Download
A view/work_state_form.xml View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A view/work_state_list.xml View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M view/work_tree.xml View 1 chunk +1 line, -1 line 0 comments Download
M view/work_tree_simple.xml View 1 chunk +1 line, -1 line 0 comments Download
M work.py View 1 2 3 4 7 chunks +149 lines, -29 lines 0 comments Download
M work.xml View 1 2 5 chunks +53 lines, -39 lines 0 comments Download

Messages

Total messages: 24
pokoli
2 months, 3 weeks ago (2018-09-27 16:24:13 UTC) #1
reviewbot
https://codereview.tryton.org/64411002/diff/1/__init__.py#newcode6 __init__.py:6: F403 'from timesheet import *' used; unable to detect undefined names https://codereview.tryton.org/64411002/diff/1/work.py#newcode145 work.py:145: ...
2 months, 3 weeks ago (2018-09-27 16:32:38 UTC) #2
albert
https://codereview.tryton.org/64411002/diff/1/view/work_state_list.xml File view/work_state_list.xml (right): https://codereview.tryton.org/64411002/diff/1/view/work_state_list.xml#newcode4 view/work_state_list.xml:4: <tree> Maybe sequence=sequence would be appropriate
1 month, 3 weeks ago (2018-10-25 14:44:55 UTC) #3
pokoli
Update to tip and set sequence on work_state_list
1 month, 1 week ago (2018-11-07 16:17:32 UTC) #4
reviewbot
https://codereview.tryton.org/64411002/diff/20001/work.py#newcode145 work.py:145: E711 comparison to None should be 'if cond is None:' URL: https://codereview.tryton.org/64411002
1 month, 1 week ago (2018-11-07 16:37:22 UTC) #5
ced
I'm wondering if we should not have some automatic update of the work_state or progress. ...
1 month ago (2018-11-14 08:39:08 UTC) #6
pokoli
Fix comments
1 month ago (2018-11-15 19:08:59 UTC) #7
pokoli
Added a mechanism to update the task state based on progress, so if you set ...
1 month ago (2018-11-15 19:12:53 UTC) #8
reviewbot
https://codereview.tryton.org/64411002/diff/40001/work.py#newcode159 work.py:159: E711 comparison to None should be 'if cond is None:' URL: https://codereview.tryton.org/64411002
1 month ago (2018-11-15 19:14:18 UTC) #9
ced
On 2018/11/15 19:12:53, pokoli wrote: > Added a mechanism to update the task state based ...
1 month ago (2018-11-15 20:26:37 UTC) #10
ced
https://codereview.tryton.org/64411002/diff/20001/work.py File work.py (left): https://codereview.tryton.org/64411002/diff/20001/work.py#oldcode231 work.py:231: if child.state == 'opened': On 2018/11/15 19:12:52, pokoli wrote: ...
1 month ago (2018-11-15 20:28:56 UTC) #11
pokoli
Set progress based on state and add missing not null migration
4 weeks, 1 day ago (2018-11-19 16:44:10 UTC) #12
pokoli
https://codereview.tryton.org/64411002/diff/20001/work.py File work.py (left): https://codereview.tryton.org/64411002/diff/20001/work.py#oldcode231 work.py:231: if child.state == 'opened': On 2018/11/15 20:28:56, ced wrote: ...
4 weeks, 1 day ago (2018-11-19 16:45:14 UTC) #13
reviewbot
https://codereview.tryton.org/64411002/diff/60001/work.py#newcode139 work.py:139: E711 comparison to None should be 'if cond is None:' URL: https://codereview.tryton.org/64411002
4 weeks, 1 day ago (2018-11-19 17:10:54 UTC) #14
ced
https://codereview.tryton.org/64411002/diff/20001/work.py File work.py (left): https://codereview.tryton.org/64411002/diff/20001/work.py#oldcode231 work.py:231: if child.state == 'opened': On 2018/11/19 16:45:14, pokoli wrote: ...
4 weeks, 1 day ago (2018-11-19 17:23:24 UTC) #15
pokoli
https://codereview.tryton.org/64411002/diff/20001/work.py File work.py (left): https://codereview.tryton.org/64411002/diff/20001/work.py#oldcode231 work.py:231: if child.state == 'opened': On 2018/11/19 17:23:23, ced wrote: ...
4 weeks, 1 day ago (2018-11-19 17:33:55 UTC) #16
ced
https://codereview.tryton.org/64411002/diff/20001/work.py File work.py (left): https://codereview.tryton.org/64411002/diff/20001/work.py#oldcode231 work.py:231: if child.state == 'opened': On 2018/11/19 17:33:55, pokoli wrote: ...
4 weeks, 1 day ago (2018-11-19 17:52:06 UTC) #17
ced
https://codereview.tryton.org/64411002/diff/20001/work.py File work.py (right): https://codereview.tryton.org/64411002/diff/20001/work.py#newcode37 work.py:37: help="Check to use by as default value for the ...
4 weeks ago (2018-11-20 08:24:08 UTC) #18
pokoli
https://codereview.tryton.org/64411002/diff/20001/work.py File work.py (left): https://codereview.tryton.org/64411002/diff/20001/work.py#oldcode231 work.py:231: if child.state == 'opened': On 2018/11/19 17:52:06, ced wrote: ...
2 weeks, 6 days ago (2018-11-28 11:43:32 UTC) #19
ced
https://codereview.tryton.org/64411002/diff/20001/work.py File work.py (left): https://codereview.tryton.org/64411002/diff/20001/work.py#oldcode231 work.py:231: if child.state == 'opened': On 2018/11/28 11:43:31, pokoli wrote: ...
2 weeks, 6 days ago (2018-11-28 12:05:10 UTC) #20
dave
Just a couple of minor suggestions. https://codereview.tryton.org/64411002/diff/60001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/64411002/diff/60001/CHANGELOG#newcode1 CHANGELOG:1: * Allow to ...
2 weeks, 6 days ago (2018-11-28 12:33:23 UTC) #21
pokoli
remove unused function, check total_progress and some wording imporvements
2 weeks, 6 days ago (2018-11-28 12:47:49 UTC) #22
pokoli
https://codereview.tryton.org/64411002/diff/20001/work.py File work.py (left): https://codereview.tryton.org/64411002/diff/20001/work.py#oldcode231 work.py:231: if child.state == 'opened': On 2018/11/28 12:05:09, ced wrote: ...
2 weeks, 6 days ago (2018-11-28 12:49:14 UTC) #23
reviewbot
2 weeks, 6 days ago (2018-11-28 13:12:34 UTC) #24
https://codereview.tryton.org/64411002/diff/80001/work.py#newcode139
work.py:139:
E711 comparison to None should be 'if cond is None:'

URL: https://codereview.tryton.org/64411002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766