Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 64441002: project_invoice: Replace duration fields by the equivalent in amount

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by pokoli
Modified:
2 months ago
Reviewers:
reviewbot, ced, albert
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Replace invoiced progress duration by progress #

Total comments: 10

Patch Set 3 : Fix remarks and update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -203 lines) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/scenario_project_invoice_effort.rst View 4 chunks +10 lines, -20 lines 0 comments Download
M tests/scenario_project_invoice_multiple_party.rst View 2 chunks +6 lines, -12 lines 0 comments Download
M tests/scenario_project_invoice_progress.rst View 5 chunks +10 lines, -20 lines 0 comments Download
M tests/scenario_project_invoice_timesheet.rst View 4 chunks +8 lines, -16 lines 0 comments Download
M view/work_form.xml View 1 chunk +2 lines, -4 lines 0 comments Download
M view/work_invoiced_progress_form.xml View 1 1 chunk +5 lines, -2 lines 0 comments Download
M view/work_invoiced_progress_list.xml View 1 1 chunk +3 lines, -1 line 0 comments Download
M work.py View 1 2 9 chunks +130 lines, -128 lines 0 comments Download

Messages

Total messages: 10
pokoli
5 months, 1 week ago (2018-10-08 14:18:39 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/64441002
5 months, 1 week ago (2018-10-08 14:34:47 UTC) #2
albert
https://codereview.tryton.org/64441002/diff/1/work.py File work.py (right): https://codereview.tryton.org/64441002/diff/1/work.py#newcode51 work.py:51: 'get_total') Why not keeping the equivalent to invoiced_duration as ...
4 months, 3 weeks ago (2018-10-25 14:21:32 UTC) #3
pokoli
https://codereview.tryton.org/64441002/diff/1/work.py File work.py (right): https://codereview.tryton.org/64441002/diff/1/work.py#newcode51 work.py:51: 'get_total') On 2018/10/25 14:21:32, albert wrote: > Why not ...
4 months, 3 weeks ago (2018-10-25 15:25:13 UTC) #4
pokoli
Replace invoiced progress duration by progress
4 months, 1 week ago (2018-11-08 13:20:21 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/64441002
4 months, 1 week ago (2018-11-08 13:44:17 UTC) #6
ced
https://codereview.tryton.org/64441002/diff/20001/work.py File work.py (right): https://codereview.tryton.org/64441002/diff/20001/work.py#newcode107 work.py:107: @staticmethod Maybe the time to change for classmethod https://codereview.tryton.org/64441002/diff/20001/work.py#newcode128 ...
2 months ago (2019-01-15 13:20:49 UTC) #7
pokoli
Fix remarks and update to tip
2 months ago (2019-01-15 13:58:39 UTC) #8
pokoli
https://codereview.tryton.org/64441002/diff/20001/work.py File work.py (right): https://codereview.tryton.org/64441002/diff/20001/work.py#newcode107 work.py:107: @staticmethod On 2019/01/15 13:20:49, ced wrote: > Maybe the ...
2 months ago (2019-01-15 13:58:57 UTC) #9
reviewbot
2 months ago (2019-01-15 14:14:26 UTC) #10
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766