Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(106)

Issue 64481002: tryton-env: Add ir.message

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 4 days ago by ced
Modified:
10 hours, 51 minutes ago
Reviewers:
dave, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 9

Patch Set 2 : Rewording and more modules #

Patch Set 3 : More modules #

Total comments: 17

Patch Set 4 : Apply dave suggestions #

Patch Set 5 : Use gettext variables and more modules #

Patch Set 6 : More modules #

Total comments: 43

Patch Set 7 : Fix remarks #

Patch Set 8 : More modules #

Patch Set 9 : More modules #

Total comments: 42
Unified diffs Side-by-side diffs Delta from patch set Stats (+1624 lines, -1022 lines) Patch
M modules/account/account.py View 1 2 3 4 5 6 10 chunks +27 lines, -49 lines 0 comments Download
A modules/account/exceptions.py View 1 2 3 4 5 1 chunk +77 lines, -0 lines 0 comments Download
M modules/account/fiscalyear.py View 1 2 3 4 5 6 9 chunks +37 lines, -30 lines 0 comments Download
M modules/account/journal.py View 1 2 3 4 5 5 chunks +16 lines, -20 lines 0 comments Download
A modules/account/message.xml View 1 2 3 4 5 6 7 1 chunk +171 lines, -0 lines 0 comments Download
M modules/account/move.py View 1 2 3 4 5 16 chunks +71 lines, -96 lines 0 comments Download
M modules/account/party.py View 1 2 3 4 5 6 6 chunks +14 lines, -30 lines 0 comments Download
M modules/account/period.py View 1 2 3 4 5 10 chunks +40 lines, -46 lines 0 comments Download
M modules/account/tax.py View 1 2 3 4 5 7 chunks +11 lines, -28 lines 0 comments Download
M modules/account/tryton.cfg View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M modules/account_asset/account.py View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -12 lines 0 comments Download
M modules/account_asset/asset.py View 1 2 3 4 5 6 7 3 chunks +5 lines, -4 lines 0 comments Download
A modules/account_asset/message.xml View 1 2 3 4 5 6 7 1 chunk +16 lines, -0 lines 6 comments Download
M modules/account_asset/purchase.py View 1 2 3 4 5 6 7 2 chunks +8 lines, -10 lines 0 comments Download
M modules/account_asset/tryton.cfg View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A modules/account_es/exceptions.py View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
A modules/account_es/message.xml View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M modules/account_es/reporting_tax.py View 1 2 3 4 chunks +5 lines, -9 lines 0 comments Download
M modules/account_es/tryton.cfg View 1 1 chunk +1 line, -0 lines 0 comments Download
A modules/account_invoice/exceptions.py View 1 2 3 4 5 6 7 1 chunk +33 lines, -0 lines 0 comments Download
M modules/account_invoice/invoice.py View 1 2 3 4 5 6 7 22 chunks +75 lines, -110 lines 0 comments Download
A modules/account_invoice/message.xml View 1 2 3 4 5 6 7 1 chunk +66 lines, -0 lines 8 comments Download
M modules/account_invoice/party.py View 1 2 3 4 5 6 7 3 chunks +7 lines, -14 lines 0 comments Download
M modules/account_invoice/payment_term.py View 1 2 3 4 5 6 7 8 chunks +18 lines, -33 lines 0 comments Download
M modules/account_invoice/tryton.cfg View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A modules/account_product/exceptions.py View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
A modules/account_statement/exceptions.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A modules/account_statement/message.xml View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
M modules/account_statement/tryton.cfg View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M modules/account_statement_aeb43/statement.py View 1 2 3 4 5 3 chunks +6 lines, -11 lines 0 comments Download
M modules/account_statement_coda/account.py View 1 2 3 4 5 3 chunks +11 lines, -20 lines 0 comments Download
A modules/authentication_sms/message.xml View 1 chunk +10 lines, -0 lines 0 comments Download
M modules/authentication_sms/res.py View 1 2 3 4 3 chunks +3 lines, -12 lines 0 comments Download
M modules/authentication_sms/tryton.cfg View 1 chunk +1 line, -0 lines 0 comments Download
M modules/bank/bank.py View 1 2 3 4 5 6 7 3 chunks +6 lines, -4 lines 0 comments Download
A modules/bank/exceptions.py View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
A modules/bank/message.xml View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M modules/bank/tryton.cfg View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M modules/currency/currency.py View 1 2 3 4 4 chunks +6 lines, -8 lines 0 comments Download
A modules/currency/exceptions.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
A modules/currency/message.xml View 1 1 chunk +10 lines, -0 lines 0 comments Download
M modules/currency/tryton.cfg View 1 1 chunk +1 line, -0 lines 0 comments Download
M modules/party/address.py View 1 2 3 4 5 chunks +9 lines, -13 lines 0 comments Download
M modules/party/contact_mechanism.py View 1 2 3 4 5 6 7 8 4 chunks +11 lines, -13 lines 0 comments Download
A modules/party/exceptions.py View 1 chunk +28 lines, -0 lines 0 comments Download
A modules/party/message.xml View 1 2 3 4 5 1 chunk +37 lines, -0 lines 0 comments Download
M modules/party/party.py View 1 2 3 4 5 11 chunks +26 lines, -55 lines 0 comments Download
M modules/party/tryton.cfg View 1 chunk +1 line, -0 lines 0 comments Download
M modules/party_siret/address.py View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -13 lines 0 comments Download
A modules/party_siret/exceptions.py View 1 2 3 4 5 6 7 8 1 chunk +12 lines, -0 lines 0 comments Download
A modules/party_siret/message.xml View 1 2 3 4 5 6 7 8 1 chunk +13 lines, -0 lines 4 comments Download
M modules/party_siret/party.py View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -12 lines 0 comments Download
M modules/party_siret/tryton.cfg View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A modules/product_price_list/exceptions.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
A modules/product_price_list/message.xml View 1 1 chunk +10 lines, -0 lines 0 comments Download
M modules/product_price_list/price_list.py View 1 2 3 4 4 chunks +8 lines, -13 lines 0 comments Download
M modules/product_price_list/tryton.cfg View 1 1 chunk +1 line, -0 lines 0 comments Download
M modules/production/bom.py View 1 2 3 4 2 chunks +1 line, -6 lines 0 comments Download
A modules/production/exceptions.py View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A modules/production/message.xml View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
M modules/production/product.py View 1 2 3 4 3 chunks +5 lines, -9 lines 0 comments Download
M modules/production/production.py View 1 2 3 4 4 chunks +8 lines, -10 lines 0 comments Download
M modules/production/tryton.cfg View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A modules/production_outsourcing/exceptions.py View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A modules/production_outsourcing/message.xml View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M modules/production_outsourcing/production.py View 1 2 3 4 4 chunks +11 lines, -11 lines 0 comments Download
M modules/production_outsourcing/tryton.cfg View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A modules/production_work/exceptions.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
A modules/production_work/message.xml View 1 2 3 4 5 6 7 1 chunk +16 lines, -0 lines 0 comments Download
M modules/production_work/production.py View 1 2 3 4 3 chunks +6 lines, -13 lines 0 comments Download
M modules/production_work/work.py View 1 2 3 4 5 chunks +10 lines, -17 lines 0 comments Download
A modules/project_invoice/exceptions.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A modules/project_invoice/message.xml View 1 2 3 4 5 6 1 chunk +22 lines, -0 lines 0 comments Download
M modules/project_invoice/timesheet.py View 1 2 3 chunks +6 lines, -10 lines 0 comments Download
M modules/project_invoice/tryton.cfg View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M modules/project_invoice/work.py View 1 2 3 4 7 chunks +24 lines, -12 lines 0 comments Download
A modules/purchase/exceptions.py View 1 2 3 4 5 6 7 1 chunk +17 lines, -0 lines 0 comments Download
M modules/purchase/invoice.py View 1 2 3 4 5 6 7 8 3 chunks +7 lines, -12 lines 0 comments Download
A modules/purchase/message.xml View 1 2 3 4 5 6 7 1 chunk +40 lines, -0 lines 20 comments Download
M modules/purchase/party.py View 1 2 3 4 5 6 7 3 chunks +7 lines, -14 lines 0 comments Download
M modules/purchase/product.py View 1 2 3 4 5 6 7 5 chunks +9 lines, -11 lines 0 comments Download
M modules/purchase/purchase.py View 1 2 3 4 5 6 7 10 chunks +31 lines, -47 lines 0 comments Download
M modules/purchase/stock.py View 1 2 3 4 5 6 7 5 chunks +8 lines, -15 lines 0 comments Download
M modules/purchase/tryton.cfg View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A modules/purchase_request/exceptions.py View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -0 lines 0 comments Download
A modules/purchase_request/message.xml View 1 2 3 4 5 6 7 8 1 chunk +19 lines, -0 lines 4 comments Download
M modules/purchase_request/purchase.py View 1 2 3 4 5 6 7 8 4 chunks +18 lines, -22 lines 0 comments Download
M modules/purchase_request/purchase_request.py View 1 2 3 4 5 6 7 8 4 chunks +9 lines, -18 lines 0 comments Download
M modules/purchase_request/tryton.cfg View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A modules/purchase_requisition/message.xml View 1 2 3 4 5 6 7 1 chunk +13 lines, -0 lines 0 comments Download
M modules/purchase_requisition/purchase.py View 1 2 3 4 5 3 chunks +8 lines, -10 lines 0 comments Download
M modules/purchase_requisition/tryton.cfg View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_promotion/exceptions.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A modules/sale_promotion/message.xml View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M modules/sale_promotion/sale.py View 1 2 3 4 4 chunks +7 lines, -14 lines 0 comments Download
M modules/sale_promotion/tryton.cfg View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_promotion_coupon/exceptions.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A modules/sale_promotion_coupon/message.xml View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M modules/sale_promotion_coupon/sale.py View 1 2 3 4 4 chunks +6 lines, -7 lines 0 comments Download
M modules/sale_promotion_coupon/tryton.cfg View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_shipment_tolerance/exceptions.py View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
A modules/sale_shipment_tolerance/message.xml View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M modules/sale_shipment_tolerance/sale.py View 1 2 3 4 5 6 7 8 3 chunks +10 lines, -11 lines 0 comments Download
M modules/sale_shipment_tolerance/tryton.cfg View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_subscription_asset/message.xml View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M modules/sale_subscription_asset/sale.py View 1 2 3 4 5 6 7 3 chunks +6 lines, -10 lines 0 comments Download
M modules/sale_subscription_asset/tryton.cfg View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_supply_drop_shipment/message.xml View 1 1 chunk +16 lines, -0 lines 0 comments Download
M modules/sale_supply_drop_shipment/purchase.py View 1 3 chunks +7 lines, -9 lines 0 comments Download
M modules/sale_supply_drop_shipment/stock.py View 1 2 3 4 4 chunks +8 lines, -8 lines 0 comments Download
M modules/sale_supply_drop_shipment/tryton.cfg View 1 chunk +1 line, -0 lines 0 comments Download
A modules/stock/exceptions.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
A modules/stock_location_move/message.xml View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M modules/stock_location_move/stock.py View 1 3 chunks +9 lines, -13 lines 0 comments Download
M modules/stock_location_move/tryton.cfg View 1 1 chunk +1 line, -0 lines 0 comments Download
A modules/stock_lot/message.xml View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M modules/stock_lot/stock.py View 1 2 3 4 7 chunks +10 lines, -24 lines 0 comments Download
M modules/stock_lot/tryton.cfg View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A modules/stock_supply/exceptions.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A modules/stock_supply_production/message.xml View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M modules/stock_supply_production/stock.py View 1 2 3 4 4 chunks +9 lines, -9 lines 0 comments Download
M modules/stock_supply_production/tryton.cfg View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A modules/timesheet/exceptions.py View 1 1 chunk +12 lines, -0 lines 0 comments Download
M modules/timesheet/line.py View 1 2 3 4 3 chunks +6 lines, -7 lines 0 comments Download
A modules/timesheet/message.xml View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M modules/timesheet/tryton.cfg View 1 1 chunk +1 line, -0 lines 0 comments Download
M modules/timesheet/work.py View 1 2 3 4 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 28
ced
3 weeks, 4 days ago (2018-11-23 08:07:37 UTC) #1
reviewbot
https://codereview.tryton.org/64481002/diff/1/modules/party/contact_mechanism.py#newcode252 modules/party/contact_mechanism.py:252: E501 line too long (82 > 79 characters) URL: https://codereview.tryton.org/64481002
3 weeks, 4 days ago (2018-11-23 08:41:28 UTC) #2
dave
Some suggestions for improvements to the error messages. https://codereview.tryton.org/64481002/diff/1/modules/party/message.xml File modules/party/message.xml (right): https://codereview.tryton.org/64481002/diff/1/modules/party/message.xml#newcode7 modules/party/message.xml:7: <field ...
3 weeks, 1 day ago (2018-11-26 13:18:29 UTC) #3
ced
3 weeks ago (2018-11-27 17:33:31 UTC) #4
reviewbot
https://codereview.tryton.org/64481002/diff/20001/modules/timesheet/work.py#newcode115 modules/timesheet/work.py:115: E712 comparison to False should be 'if cond is False:' or 'if not ...
3 weeks ago (2018-11-27 17:48:49 UTC) #5
ced
2 weeks, 6 days ago (2018-11-28 23:13:41 UTC) #6
reviewbot
https://codereview.tryton.org/64481002/diff/40001/modules/timesheet/work.py#newcode115 modules/timesheet/work.py:115: E712 comparison to False should be 'if cond is False:' or 'if not ...
2 weeks, 6 days ago (2018-11-28 23:39:53 UTC) #7
dave
These are mainly suggestions for improving the error messages. https://codereview.tryton.org/64481002/diff/40001/modules/account_es/message.xml File modules/account_es/message.xml (right): https://codereview.tryton.org/64481002/diff/40001/modules/account_es/message.xml#newcode7 modules/account_es/message.xml:7: ...
2 weeks, 5 days ago (2018-11-29 17:44:53 UTC) #8
ced
2 weeks, 5 days ago (2018-11-29 23:11:06 UTC) #9
reviewbot
https://codereview.tryton.org/64481002/diff/60001/modules/timesheet/work.py#newcode115 modules/timesheet/work.py:115: E712 comparison to False should be 'if cond is False:' or 'if not ...
2 weeks, 5 days ago (2018-11-29 23:47:43 UTC) #10
ced
2 weeks, 5 days ago (2018-11-30 00:01:50 UTC) #11
reviewbot
https://codereview.tryton.org/64481002/diff/80001/modules/timesheet/work.py#newcode115 modules/timesheet/work.py:115: E712 comparison to False should be 'if cond is False:' or 'if not ...
2 weeks, 5 days ago (2018-11-30 00:20:07 UTC) #12
ced
2 weeks, 2 days ago (2018-12-02 21:07:16 UTC) #13
reviewbot
https://codereview.tryton.org/64481002/diff/100001/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/64481002/diff/100001/modules/account/move.py#newcode413 modules/account/move.py:413: E731 do not assign ...
2 weeks, 2 days ago (2018-12-02 21:10:27 UTC) #14
dave
https://codereview.tryton.org/64481002/diff/100001/modules/account/message.xml File modules/account/message.xml (right): https://codereview.tryton.org/64481002/diff/100001/modules/account/message.xml#newcode10 modules/account/message.xml:10: <field name="text">You cannot modify or delete period "%(period)s" that ...
2 weeks, 1 day ago (2018-12-03 11:15:26 UTC) #15
ced
https://codereview.tryton.org/64481002/diff/100001/modules/account/message.xml File modules/account/message.xml (right): https://codereview.tryton.org/64481002/diff/100001/modules/account/message.xml#newcode10 modules/account/message.xml:10: <field name="text">You cannot modify or delete period "%(period)s" that ...
2 weeks, 1 day ago (2018-12-03 11:36:14 UTC) #16
dave
https://codereview.tryton.org/64481002/diff/100001/modules/account/message.xml File modules/account/message.xml (right): https://codereview.tryton.org/64481002/diff/100001/modules/account/message.xml#newcode10 modules/account/message.xml:10: <field name="text">You cannot modify or delete period "%(period)s" that ...
2 weeks, 1 day ago (2018-12-03 13:38:29 UTC) #17
ced
1 week, 6 days ago (2018-12-05 22:10:09 UTC) #18
reviewbot
https://codereview.tryton.org/64481002/diff/120001/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/64481002/diff/120001/modules/account/move.py#newcode413 modules/account/move.py:413: E731 do not assign ...
1 week, 6 days ago (2018-12-05 22:40:32 UTC) #19
ced
https://codereview.tryton.org/64481002/diff/100001/modules/account/message.xml File modules/account/message.xml (right): https://codereview.tryton.org/64481002/diff/100001/modules/account/message.xml#newcode10 modules/account/message.xml:10: <field name="text">You cannot modify or delete period "%(period)s" that ...
1 week, 4 days ago (2018-12-07 09:51:40 UTC) #20
dave
https://codereview.tryton.org/64481002/diff/100001/modules/account/message.xml File modules/account/message.xml (right): https://codereview.tryton.org/64481002/diff/100001/modules/account/message.xml#newcode83 modules/account/message.xml:83: <field name="text">You cannot erase party "%(party)s" as long as ...
1 week, 4 days ago (2018-12-07 15:48:52 UTC) #21
ced
2 days, 6 hours ago (2018-12-16 20:26:22 UTC) #22
reviewbot
https://codereview.tryton.org/64481002/diff/140001/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/64481002/diff/140001/modules/account/move.py#newcode413 modules/account/move.py:413: E731 do not assign ...
2 days, 5 hours ago (2018-12-16 20:46:05 UTC) #23
ced
2 days, 3 hours ago (2018-12-16 23:26:30 UTC) #24
reviewbot
https://codereview.tryton.org/64481002/diff/160001/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/64481002/diff/160001/modules/account/move.py#newcode413 modules/account/move.py:413: E731 do not assign ...
2 days, 2 hours ago (2018-12-16 23:37:56 UTC) #25
dave
A few suggestions for the modules that have been recently added. https://codereview.tryton.org/64481002/diff/160001/modules/account_asset/message.xml File modules/account_asset/message.xml (right): ...
1 day, 12 hours ago (2018-12-17 14:12:03 UTC) #26
ced
https://codereview.tryton.org/64481002/diff/160001/modules/account_asset/message.xml File modules/account_asset/message.xml (right): https://codereview.tryton.org/64481002/diff/160001/modules/account_asset/message.xml#newcode7 modules/account_asset/message.xml:7: <field name="text">You cannot delete asset "%(asset)s" because it is ...
1 day, 5 hours ago (2018-12-17 21:10:16 UTC) #27
dave
10 hours, 52 minutes ago (2018-12-18 15:37:29 UTC) #28
https://codereview.tryton.org/64481002/diff/160001/modules/account_asset/mess...
File modules/account_asset/message.xml (right):

https://codereview.tryton.org/64481002/diff/160001/modules/account_asset/mess...
modules/account_asset/message.xml:7: <field name="text">You cannot delete asset
"%(asset)s" because it is not in "draft" state.</field>
On 2018/12/17 21:10:15, ced wrote:
> On 2018/12/17 14:12:02, dave wrote:
> > To delete asset "%(asset)s", it must be in a "draft" state.
> 
> For me, it is a bad message because there is no action the user can do.

Ah, okay, the "because it is not in a draft state" part made me think it was
possible to change the state of the asset to "draft", sorry.

In that case:
in "draft" -> in the "Draft"
or
in "draft" -> in a draft

https://codereview.tryton.org/64481002/diff/160001/modules/account_asset/mess...
modules/account_asset/message.xml:10: <field name="text">You cannot close period
"%(period)s" because some assets "%(assets)s" have still lines without
move.</field>
On 2018/12/17 21:10:15, ced wrote:
> On 2018/12/17 14:12:02, dave wrote:
> > To close period "%(period)s", assets "%(assets)s" must all have lines with
> > moves.
> 
> I do not find this more meaningful for the user.
> If we cannot provide the procedure to close the period, I think we should stay
> with the schema "you cannot ... because ...".

Okay, then:

have still lines without move -> still have lines without moves

https://codereview.tryton.org/64481002/diff/160001/modules/account_invoice/me...
File modules/account_invoice/message.xml (right):

https://codereview.tryton.org/64481002/diff/160001/modules/account_invoice/me...
modules/account_invoice/message.xml:10: <field name="text">To compute term, you
must append a remainder line on payment term "%(payment_term)s".</field>
On 2018/12/17 21:10:15, ced wrote:
> On 2018/12/17 14:12:02, dave wrote:
> > Would this work?
> > 
> > To calculate payment term "%(payment_term)s", you must append a remainder
line
> > to it.
> 
> I do not think so. We compute terms based on payment term.

Looking at the code I can see why I misunderstood the error message.

So what about?
To calculate the payment dates, you must append a remainder line on payment term
"%(payment_term)s".

https://codereview.tryton.org/64481002/diff/160001/modules/account_invoice/me...
modules/account_invoice/message.xml:16: <field name="text">You cannot erase
party "%(party)s" while they have pending invoice with company
"%(company)s".</field>
On 2018/12/17 21:10:15, ced wrote:
> On 2018/12/17 14:12:02, dave wrote:
> > To erase party "%(party)s", they must have no pending invoices with company
> > "%(company)s".
> 
> I reuse the same sentence as for every other similar message.

Okay, no problem. Where possible when any changes were needed I was trying to
provide suggestions that "begin with the objective"
(https://material.io/design/communication/writing.html#content-structure).

So keep it in the same format as the other messages then:
invoice -> invoices

or alternatively:
have pending -> have a pending

https://codereview.tryton.org/64481002/diff/160001/modules/purchase/message.xml
File modules/purchase/message.xml (right):

https://codereview.tryton.org/64481002/diff/160001/modules/purchase/message.x...
modules/purchase/message.xml:7: <field name="text">You try to change the
purchase UOM but the purchase prices are based on it.</field>
On 2018/12/17 21:10:16, ced wrote:
> On 2018/12/17 14:12:02, dave wrote:
> > You cannot change the purchase UoM because the purchase prices are based on
> it.
> 
> This is a message for a warning. So it is not forbidden.

Ah, sorry, the "but" part makes the message read like it is forbidden.

What about?
You are trying to change the purchase UoM on which the purchase prices are
based.

https://codereview.tryton.org/64481002/diff/160001/modules/purchase/message.x...
modules/purchase/message.xml:22: <field name="text">To invoice purchase
"%(purchase)s", you must set an account expense on product
"%(product)s".</field>
On 2018/12/17 21:10:15, ced wrote:
> On 2018/12/17 14:12:02, dave wrote:
> > account expense -> expense account
> 
> I use the label of the field because it will help the user.

Okay, I see, then as it's the name of a field what about?
an account expense -> the "Account Expense"

https://codereview.tryton.org/64481002/diff/160001/modules/purchase/message.x...
modules/purchase/message.xml:31: <field name="text">To modify header of purchase
"%(purchase)s", it must be in "draft" state.</field>
Just spotted this:
in "draft" -> in the "Draft"
or:
in "draft" -> in a draft
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766