Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(200)

Issue 64541002: tryton-env: Remove starting wildcard when searching on codes and numbers

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 4 days ago by pokoli
Modified:
11 hours, 35 minutes ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add changelogs, only use code for *like and manage %% #

Total comments: 3

Patch Set 3 : Add helper function and use it on modules #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -16 lines) Patch
M modules/account/CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
M modules/account/account.py View 1 2 3 chunks +9 lines, -3 lines 0 comments Download
M modules/account/journal.py View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M modules/account/tax.py View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M modules/bank/CHANGELOG View 1 1 chunk +2 lines, -0 lines 0 comments Download
M modules/bank/party.py View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M modules/country/CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
M modules/country/country.py View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M modules/party/CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
M modules/party/party.py View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M modules/product/CHANGELOG View 1 1 chunk +2 lines, -0 lines 0 comments Download
M modules/product/product.py View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M modules/purchase/CHANGELOG View 1 1 chunk +2 lines, -0 lines 0 comments Download
M modules/purchase/product.py View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M trytond/CHANGELOG View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M trytond/trytond/tests/test_tools.py View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M trytond/trytond/tools/misc.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10
pokoli
2 weeks, 4 days ago (2019-01-03 12:16:00 UTC) #1
ced
Missing changelog entries https://codereview.tryton.org/64541002/diff/1/modules/account/account.py File modules/account/account.py (right): https://codereview.tryton.org/64541002/diff/1/modules/account/account.py#newcode427 modules/account/account.py:427: code_value = clause[2][1:] if clause[2].startswith('%') else ...
2 weeks, 4 days ago (2019-01-03 12:29:46 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/64541002
2 weeks, 4 days ago (2019-01-03 12:49:49 UTC) #3
pokoli
Add changelogs, only use code for *like and manage %%
1 week, 6 days ago (2019-01-08 18:20:57 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/64541002
1 week, 6 days ago (2019-01-08 18:46:30 UTC) #5
ced
https://codereview.tryton.org/64541002/diff/20001/modules/account/account.py File modules/account/account.py (right): https://codereview.tryton.org/64541002/diff/20001/modules/account/account.py#newcode429 modules/account/account.py:429: code_value = clause[2][clause[2].rfind('%', 0, 2) + 1:] I do ...
6 days, 12 hours ago (2019-01-15 14:12:54 UTC) #6
pokoli
https://codereview.tryton.org/64541002/diff/20001/modules/account/account.py File modules/account/account.py (right): https://codereview.tryton.org/64541002/diff/20001/modules/account/account.py#newcode429 modules/account/account.py:429: code_value = clause[2][clause[2].rfind('%', 0, 2) + 1:] On 2019/01/15 ...
4 days, 18 hours ago (2019-01-17 07:50:07 UTC) #7
ced
https://codereview.tryton.org/64541002/diff/20001/modules/account/account.py File modules/account/account.py (right): https://codereview.tryton.org/64541002/diff/20001/modules/account/account.py#newcode429 modules/account/account.py:429: code_value = clause[2][clause[2].rfind('%', 0, 2) + 1:] On 2019/01/17 ...
4 days, 17 hours ago (2019-01-17 08:44:18 UTC) #8
pokoli
Add helper function and use it on modules
11 hours, 39 minutes ago (2019-01-21 14:35:41 UTC) #9
reviewbot
11 hours, 35 minutes ago (2019-01-21 14:39:07 UTC) #10
patch is not applicable
URL: https://codereview.tryton.org/64541002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766