Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(841)

Issue 64571002: account_invoice: set paid state if invoice is already reconciled when posted

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days ago by semarie
Modified:
14 hours, 12 minutes ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

account_invoice: set paid state if invoice is already reconciled when posted issue7999

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M invoice.py View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 3
semarie
5 days ago (2019-02-11 19:18:05 UTC) #1
reviewbot
https://codereview.tryton.org/64571002/diff/1/invoice.py#newcode580 invoice.py:580: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/64571002
5 days ago (2019-02-11 19:46:28 UTC) #2
ced
22 hours, 19 minutes ago (2019-02-15 21:48:01 UTC) #3
I think it deserves to have a scenario to test this case.

https://codereview.tryton.org/64571002/diff/1/invoice.py
File invoice.py (right):

https://codereview.tryton.org/64571002/diff/1/invoice.py#newcode1361
invoice.py:1361: cls.paid(paids)
Not sure this will work as at this point the invoice should still be validated
and no transition exists.

https://codereview.tryton.org/64571002/diff/1/invoice.py#newcode1361
invoice.py:1361: cls.paid(paids)
I'm wondering if it is not better to call process from the queue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766