Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 66001: New module sale_rebate for 2.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by ced
Modified:
1 year, 6 months ago
Visibility:
Public.

Patch Set 1 #

Total comments: 14

Patch Set 2 : Fix yangoon comments #

Total comments: 7

Patch Set 3 : Fix oscar comments #

Patch Set 4 : Update to 2.2 #

Patch Set 5 : Simplify PYSON #

Total comments: 4

Patch Set 6 : Fix mathiasb comments #

Total comments: 5

Patch Set 7 : Store list_price #

Patch Set 8 : Fix and add support for account_invoice_rebate #

Total comments: 13

Patch Set 9 : Fix udono comment #

Total comments: 1

Patch Set 10 : Fix yangoon comments #

Patch Set 11 : Fix on_change_quantity and on_change_unit_price #

Patch Set 12 : Fix get_invoice_line return a list #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+1322 lines, -0 lines) Patch
A COPYRIGHT View 1 chunk +15 lines, -0 lines 0 comments Download
A INSTALL View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A README View 1 chunk +36 lines, -0 lines 0 comments Download
A __init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
A __tryton__.py View 1 2 3 4 5 6 7 8 9 1 chunk +23 lines, -0 lines 2 comments Download
A doc/index.rst View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -0 lines 0 comments Download
A sale.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +142 lines, -0 lines 2 comments Download
A sale.xml View 1 2 1 chunk +61 lines, -0 lines 1 comment Download
A setup.py View 1 2 3 4 5 6 7 8 1 chunk +70 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
A tests/scenario_sale_rebate.rst View 1 2 3 4 5 6 7 8 1 chunk +181 lines, -0 lines 0 comments Download
A tests/test_sale_rebate.py View 1 2 3 4 5 6 7 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 28
ced
10 years, 11 months ago (2011-07-17 21:05:27 UTC) #1
yangoon
http://codereview.tryton.org/66001/diff/1/INSTALL File INSTALL (right): http://codereview.tryton.org/66001/diff/1/INSTALL#newcode7 INSTALL:7: * Python 2.5 or later (http://www.python.org/) 2.6 for trunk ...
10 years, 11 months ago (2011-07-17 22:55:57 UTC) #2
ced
http://codereview.tryton.org/66001/diff/1/INSTALL File INSTALL (right): http://codereview.tryton.org/66001/diff/1/INSTALL#newcode7 INSTALL:7: * Python 2.5 or later (http://www.python.org/) On 2011/07/17 22:55:57, ...
10 years, 11 months ago (2011-07-18 08:08:00 UTC) #3
ced
10 years, 11 months ago (2011-07-18 08:08:10 UTC) #4
yangoon
http://codereview.tryton.org/66001/diff/17/sale.py File sale.py (right): http://codereview.tryton.org/66001/diff/17/sale.py#newcode74 sale.py:74: unit_price = (1 - (rebate / 100)) * list_price ...
10 years, 11 months ago (2011-07-19 13:53:57 UTC) #5
ced
http://codereview.tryton.org/66001/diff/17/sale.py File sale.py (right): http://codereview.tryton.org/66001/diff/17/sale.py#newcode74 sale.py:74: unit_price = (1 - (rebate / 100)) * list_price ...
10 years, 11 months ago (2011-07-19 14:21:50 UTC) #6
plantian
Suggestion for doc. http://codereview.tryton.org/66001/diff/17/doc/index.rst File doc/index.rst (right): http://codereview.tryton.org/66001/diff/17/doc/index.rst#newcode9 doc/index.rst:9: - *Rebate*: The rebate computed between ...
10 years, 11 months ago (2011-07-21 18:23:38 UTC) #7
oscaralvarez
Please review the comments for to fix something bugs, in sale.xml http://codereview.tryton.org/66001/diff/17/sale.xml File sale.xml (right): ...
10 years, 11 months ago (2011-07-25 12:38:19 UTC) #8
ced
http://codereview.tryton.org/66001/diff/17/sale.xml File sale.xml (right): http://codereview.tryton.org/66001/diff/17/sale.xml#newcode27 sale.xml:27: <field name="inherit" ref="sale.sale_view_form"/> On 2011/07/25 12:38:20, oscar.alvarez.montero wrote: > ...
10 years, 11 months ago (2011-07-25 13:43:36 UTC) #9
ced
10 years, 11 months ago (2011-07-25 13:43:57 UTC) #10
ced
10 years, 7 months ago (2011-11-26 15:16:54 UTC) #11
ced
10 years, 7 months ago (2011-11-26 17:33:19 UTC) #12
yangoon
http://codereview.tryton.org/66001/diff/18002/INSTALL File INSTALL (right): http://codereview.tryton.org/66001/diff/18002/INSTALL#newcode7 INSTALL:7: * Python 2.5 or later (http://www.python.org/) Python version is ...
10 years, 7 months ago (2011-11-27 11:19:08 UTC) #13
ced
10 years, 7 months ago (2011-11-27 12:03:36 UTC) #14
yangoon
Two comments, otherwise LGTM http://codereview.tryton.org/66001/diff/16006/sale.py File sale.py (right): http://codereview.tryton.org/66001/diff/16006/sale.py#newcode19 sale.py:19: 'get_list_price') Hmm, this mode of ...
10 years, 7 months ago (2011-11-27 18:22:07 UTC) #15
ced
http://codereview.tryton.org/66001/diff/16006/sale.py File sale.py (right): http://codereview.tryton.org/66001/diff/16006/sale.py#newcode19 sale.py:19: 'get_list_price') On 2011/11/27 18:22:08, yangoon wrote: > Hmm, this ...
10 years, 7 months ago (2011-11-27 19:17:49 UTC) #16
ced
http://codereview.tryton.org/66001/diff/16006/sale.py File sale.py (right): http://codereview.tryton.org/66001/diff/16006/sale.py#newcode14 sale.py:14: list_price = fields.Function(fields.Numeric('List Price', digits=(16, 4), I'm wondering if ...
10 years, 7 months ago (2011-12-05 13:51:09 UTC) #17
ced
10 years, 6 months ago (2011-12-25 16:33:53 UTC) #18
ced
10 years, 6 months ago (2011-12-25 21:52:30 UTC) #19
udono2
http://codereview.tryton.org/66001/diff/27018/INSTALL File INSTALL (right): http://codereview.tryton.org/66001/diff/27018/INSTALL#newcode15 INSTALL:15: Once you've downloaded and unpacked the trytond_sale_rebate source release, ...
10 years, 6 months ago (2011-12-27 17:30:56 UTC) #20
ced
http://codereview.tryton.org/66001/diff/27018/doc/index.rst File doc/index.rst (right): http://codereview.tryton.org/66001/diff/27018/doc/index.rst#newcode9 doc/index.rst:9: - *Rebate*: The rebate computed between *List Price* and ...
10 years, 6 months ago (2012-01-02 13:21:58 UTC) #21
ced
10 years, 6 months ago (2012-01-02 13:22:14 UTC) #22
yangoon
http://codereview.tryton.org/66001/diff/27020/__tryton__.py File __tryton__.py (right): http://codereview.tryton.org/66001/diff/27020/__tryton__.py#newcode1 __tryton__.py:1: #This file is part of Tryton. The COPYRIGHT file ...
10 years, 6 months ago (2012-01-02 17:45:17 UTC) #23
ced
10 years, 5 months ago (2012-01-22 18:41:49 UTC) #24
jc.michel
Hi, The rebate is rightly displayed now. But I get this trace and error when ...
10 years, 5 months ago (2012-01-22 20:26:01 UTC) #25
ced
10 years, 5 months ago (2012-01-22 20:34:45 UTC) #26
udono2
The module looks good so far. I like the possibility to enter negative percentages. When ...
9 years, 10 months ago (2012-08-18 07:13:40 UTC) #27
Okko
9 years, 7 months ago (2012-11-20 17:17:48 UTC) #28

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted