Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(205)

Issue 66271002: sao: Add notifications management

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 4 days ago by nicoe
Modified:
2 days, 4 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add CHANGELOG #

Patch Set 3 : Check that session did not change #

Total comments: 11

Patch Set 4 : Add service-worker first draft #

Total comments: 2

Patch Set 5 : Revert to version without worker & without action handling #

Patch Set 6 : fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1 line) Patch
M CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
M Gruntfile.js View 4 1 chunk +2 lines, -1 line 0 comments Download
A src/notification.js View 1 2 3 4 1 chunk +64 lines, -0 lines 0 comments Download
M src/sao.js View 1 2 3 4 5 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 16
nicoe
2 weeks, 4 days ago (2018-06-27 16:55:40 UTC) #1
nicoe
Add CHANGELOG
2 weeks, 4 days ago (2018-06-27 16:56:21 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/66271002
2 weeks, 4 days ago (2018-06-27 16:58:16 UTC) #3
nicoe
Check that session did not change
2 weeks, 4 days ago (2018-06-27 17:23:48 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/66271002
2 weeks, 4 days ago (2018-06-27 17:33:43 UTC) #5
ced
https://codereview.tryton.org/66271002/diff/40001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode25 src/notification.js:25: }); Should not a timeout be set? https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode32 src/notification.js:32: ...
2 weeks, 3 days ago (2018-06-28 14:44:48 UTC) #6
nicoe
https://codereview.tryton.org/66271002/diff/40001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode25 src/notification.js:25: }); On 2018/06/28 14:44:47, ced wrote: > Should not ...
2 weeks, 3 days ago (2018-06-28 15:50:28 UTC) #7
ced
https://codereview.tryton.org/66271002/diff/40001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode25 src/notification.js:25: }); On 2018/06/28 15:50:27, nicoe wrote: > On 2018/06/28 ...
2 weeks, 3 days ago (2018-06-28 16:19:10 UTC) #8
nicoe
https://codereview.tryton.org/66271002/diff/40001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode25 src/notification.js:25: }); On 2018/06/28 16:19:10, ced wrote: > On 2018/06/28 ...
2 weeks, 3 days ago (2018-06-28 16:43:33 UTC) #9
ced
https://codereview.tryton.org/66271002/diff/40001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode25 src/notification.js:25: }); On 2018/06/28 16:43:33, nicoe wrote: > On 2018/06/28 ...
2 weeks, 3 days ago (2018-06-28 17:41:56 UTC) #10
nicoe
Add service-worker first draft
5 days, 4 hours ago (2018-07-10 16:27:04 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/66271002
5 days, 4 hours ago (2018-07-10 16:40:39 UTC) #12
ced
https://codereview.tryton.org/66271002/diff/60001/src/service-worker/notification.js File src/service-worker/notification.js (right): https://codereview.tryton.org/66271002/diff/60001/src/service-worker/notification.js#newcode9 src/service-worker/notification.js:9: self.promises = {}; I do not think it is ...
4 days, 9 hours ago (2018-07-11 11:46:26 UTC) #13
nicoe
Revert to version without worker & without action handling
2 days, 5 hours ago (2018-07-13 15:50:05 UTC) #14
nicoe
fix indentation
2 days, 5 hours ago (2018-07-13 16:02:01 UTC) #15
reviewbot
2 days, 4 hours ago (2018-07-13 16:17:46 UTC) #16
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69