Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 66271002: sao: Add notifications management (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by nicoe
Modified:
3 months, 1 week ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add CHANGELOG #

Patch Set 3 : Check that session did not change #

Total comments: 11

Patch Set 4 : Add service-worker first draft #

Total comments: 2

Patch Set 5 : Revert to version without worker & without action handling #

Patch Set 6 : fix indentation #

Total comments: 8

Patch Set 7 : fix remarks & add icon support #

Total comments: 10

Patch Set 8 : Fix remark and use bus names #

Total comments: 13

Patch Set 9 : fix remarks #

Patch Set 10 : update to tip #

Total comments: 8

Patch Set 11 : Fix remarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -2 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M Gruntfile.js View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M index.html View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
A src/bus.js View 1 2 3 4 5 6 7 8 9 10 1 chunk +84 lines, -0 lines 0 comments Download
M src/sao.js View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M src/session.js View 1 2 3 4 5 6 7 8 9 10 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 36
nicoe
4 months, 3 weeks ago (2018-06-27 16:55:40 UTC) #1
nicoe
Add CHANGELOG
4 months, 3 weeks ago (2018-06-27 16:56:21 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/66271002
4 months, 3 weeks ago (2018-06-27 16:58:16 UTC) #3
nicoe
Check that session did not change
4 months, 3 weeks ago (2018-06-27 17:23:48 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/66271002
4 months, 3 weeks ago (2018-06-27 17:33:43 UTC) #5
ced
https://codereview.tryton.org/66271002/diff/40001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode25 src/notification.js:25: }); Should not a timeout be set? https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode32 src/notification.js:32: ...
4 months, 3 weeks ago (2018-06-28 14:44:48 UTC) #6
nicoe
https://codereview.tryton.org/66271002/diff/40001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode25 src/notification.js:25: }); On 2018/06/28 14:44:47, ced wrote: > Should not ...
4 months, 3 weeks ago (2018-06-28 15:50:28 UTC) #7
ced
https://codereview.tryton.org/66271002/diff/40001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode25 src/notification.js:25: }); On 2018/06/28 15:50:27, nicoe wrote: > On 2018/06/28 ...
4 months, 3 weeks ago (2018-06-28 16:19:10 UTC) #8
nicoe
https://codereview.tryton.org/66271002/diff/40001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode25 src/notification.js:25: }); On 2018/06/28 16:19:10, ced wrote: > On 2018/06/28 ...
4 months, 3 weeks ago (2018-06-28 16:43:33 UTC) #9
ced
https://codereview.tryton.org/66271002/diff/40001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/40001/src/notification.js#newcode25 src/notification.js:25: }); On 2018/06/28 16:43:33, nicoe wrote: > On 2018/06/28 ...
4 months, 3 weeks ago (2018-06-28 17:41:56 UTC) #10
nicoe
Add service-worker first draft
4 months, 1 week ago (2018-07-10 16:27:04 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/66271002
4 months, 1 week ago (2018-07-10 16:40:39 UTC) #12
ced
https://codereview.tryton.org/66271002/diff/60001/src/service-worker/notification.js File src/service-worker/notification.js (right): https://codereview.tryton.org/66271002/diff/60001/src/service-worker/notification.js#newcode9 src/service-worker/notification.js:9: self.promises = {}; I do not think it is ...
4 months, 1 week ago (2018-07-11 11:46:26 UTC) #13
nicoe
Revert to version without worker & without action handling
4 months, 1 week ago (2018-07-13 15:50:05 UTC) #14
nicoe
fix indentation
4 months, 1 week ago (2018-07-13 16:02:01 UTC) #15
reviewbot
flake8 OK URL: https://codereview.tryton.org/66271002
4 months, 1 week ago (2018-07-13 16:17:46 UTC) #16
ced
https://codereview.tryton.org/66271002/diff/100001/src/sao.js File src/sao.js (right): https://codereview.tryton.org/66271002/diff/100001/src/sao.js#newcode230 src/sao.js:230: I would prefer to have generate_token here instead of ...
4 months ago (2018-07-16 08:44:46 UTC) #17
nicoe
https://codereview.tryton.org/66271002/diff/100001/src/sao.js File src/sao.js (right): https://codereview.tryton.org/66271002/diff/100001/src/sao.js#newcode230 src/sao.js:230: On 2018/07/16 08:44:46, ced wrote: > I would prefer ...
4 months ago (2018-07-18 14:28:28 UTC) #18
nicoe
fix remarks & add icon support
4 months ago (2018-07-18 14:29:52 UTC) #19
reviewbot
patch is not applicable URL: https://codereview.tryton.org/66271002
4 months ago (2018-07-18 14:30:11 UTC) #20
ced
https://codereview.tryton.org/66271002/diff/120001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/120001/src/notification.js#newcode26 src/notification.js:26: timeout: 10 * 60 * 1000 ending , https://codereview.tryton.org/66271002/diff/120001/src/notification.js#newcode42 ...
4 months ago (2018-07-19 09:54:11 UTC) #21
nicoe
https://codereview.tryton.org/66271002/diff/120001/src/notification.js File src/notification.js (right): https://codereview.tryton.org/66271002/diff/120001/src/notification.js#newcode26 src/notification.js:26: timeout: 10 * 60 * 1000 On 2018/07/19 09:54:10, ...
3 months, 3 weeks ago (2018-07-23 16:47:00 UTC) #22
nicoe
Fix remark and use bus names
3 months, 3 weeks ago (2018-07-23 16:47:53 UTC) #23
reviewbot
patch is not applicable URL: https://codereview.tryton.org/66271002
3 months, 3 weeks ago (2018-07-23 17:02:27 UTC) #24
ced
https://codereview.tryton.org/66271002/diff/140001/src/bus.js File src/bus.js (right): https://codereview.tryton.org/66271002/diff/140001/src/bus.js#newcode52 src/bus.js:52: Sao.Bus.listen(timestamp); It should also check the session did not ...
3 months, 3 weeks ago (2018-07-23 17:35:08 UTC) #25
ced
https://codereview.tryton.org/66271002/diff/140001/src/bus.js File src/bus.js (right): https://codereview.tryton.org/66271002/diff/140001/src/bus.js#newcode19 src/bus.js:19: Sao.Bus.id = generate_token(); I do not see it set ...
3 months, 3 weeks ago (2018-07-23 17:56:56 UTC) #26
nicoe
https://codereview.tryton.org/66271002/diff/140001/src/bus.js File src/bus.js (right): https://codereview.tryton.org/66271002/diff/140001/src/bus.js#newcode19 src/bus.js:19: Sao.Bus.id = generate_token(); On 2018/07/23 17:56:55, ced wrote: > ...
3 months, 3 weeks ago (2018-07-24 14:13:40 UTC) #27
ced
https://codereview.tryton.org/66271002/diff/140001/src/sao.js File src/sao.js (right): https://codereview.tryton.org/66271002/diff/140001/src/sao.js#newcode492 src/sao.js:492: Notification.requestPermission().then(function () { On 2018/07/24 14:13:40, nicoe wrote: > ...
3 months, 3 weeks ago (2018-07-24 14:50:57 UTC) #28
nicoe
fix remarks
3 months, 3 weeks ago (2018-07-24 15:03:25 UTC) #29
reviewbot
patch is not applicable URL: https://codereview.tryton.org/66271002
3 months, 3 weeks ago (2018-07-24 15:13:02 UTC) #30
nicoe
update to tip
3 months, 3 weeks ago (2018-07-24 15:18:25 UTC) #31
reviewbot
flake8 OK URL: https://codereview.tryton.org/66271002
3 months, 3 weeks ago (2018-07-24 15:41:37 UTC) #32
ced
https://codereview.tryton.org/66271002/diff/180001/src/bus.js File src/bus.js (right): https://codereview.tryton.org/66271002/diff/180001/src/bus.js#newcode34 src/bus.js:34: bus_id: Sao.Bus.id missing trailing comma https://codereview.tryton.org/66271002/diff/180001/src/bus.js#newcode51 src/bus.js:51: if ((error ...
3 months, 3 weeks ago (2018-07-24 16:23:46 UTC) #33
nicoe
https://codereview.tryton.org/66271002/diff/180001/src/bus.js File src/bus.js (right): https://codereview.tryton.org/66271002/diff/180001/src/bus.js#newcode34 src/bus.js:34: bus_id: Sao.Bus.id On 2018/07/24 16:23:45, ced wrote: > missing ...
3 months, 3 weeks ago (2018-07-25 08:41:44 UTC) #34
nicoe
Fix remarks
3 months, 3 weeks ago (2018-07-25 08:44:40 UTC) #35
reviewbot
3 months, 3 weeks ago (2018-07-25 09:01:25 UTC) #36
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766