Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(178)

Issue 66341002: tryton-env: Add bus system (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by nicoe
Modified:
1 month ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Add bus system issue7537

Patch Set 1 #

Total comments: 28

Patch Set 2 : Fix remarks #

Total comments: 17

Patch Set 3 : Use channels & fix remarks #

Patch Set 4 : Update to tip #

Total comments: 52

Patch Set 5 : New queue implementation to support concurrent trytonds & fix remarks #

Patch Set 6 : Use CONNECTION in the tryton listen call #

Total comments: 77

Patch Set 7 : Fix remarks #

Total comments: 3

Patch Set 8 : Fix remarks, fix corner case in the Message Queue, fix reconnection #

Patch Set 9 : Add MessageQueue testcase #

Total comments: 15

Patch Set 10 : fix remarks #

Total comments: 4

Patch Set 11 : fix exception handling #

Total comments: 5

Patch Set 12 : fix remarks #

Total comments: 1

Patch Set 13 : update to tip #

Patch Set 14 : Do not handle HTTPError separately #

Unified diffs Side-by-side diffs Delta from patch set Stats (+720 lines, -10 lines) Patch
M sao/CHANGELOG View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M sao/Gruntfile.js View 1 chunk +2 lines, -1 line 0 comments Download
M sao/index.html View 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A sao/src/bus.js View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +78 lines, -0 lines 0 comments Download
M sao/src/common.js View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M sao/src/sao.js View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -0 lines 0 comments Download
M sao/src/session.js View 1 2 3 4 5 6 3 chunks +9 lines, -3 lines 0 comments Download
M tryton/CHANGELOG View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
A tryton/tryton/bus.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +83 lines, -0 lines 0 comments Download
M tryton/tryton/common/common.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M tryton/tryton/config.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M tryton/tryton/gui/main.py View 1 2 3 4 5 6 3 chunks +10 lines, -0 lines 0 comments Download
M tryton/tryton/jsonrpc.py View 1 2 3 4 5 3 chunks +17 lines, -3 lines 0 comments Download
M tryton/tryton/rpc.py View 1 2 3 4 5 6 3 chunks +11 lines, -0 lines 0 comments Download
M trytond/CHANGELOG View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A trytond/doc/ref/bus.rst View 1 2 3 4 5 6 1 chunk +103 lines, -0 lines 0 comments Download
A trytond/doc/topics/bus.rst View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
M trytond/doc/topics/configuration.rst View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
M trytond/trytond/backend/postgresql/database.py View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A trytond/trytond/bus.py View 1 2 3 4 5 6 7 8 9 1 chunk +250 lines, -0 lines 0 comments Download
M trytond/trytond/config.py View 1 2 3 4 5 6 7 2 chunks +5 lines, -0 lines 0 comments Download
A trytond/trytond/tests/test_bus.py View 1 2 3 4 5 6 7 8 1 chunk +75 lines, -0 lines 0 comments Download
M trytond/trytond/transaction.py View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M trytond/trytond/wsgi.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 54
reviewbot
https://codereview.tryton.org/66341002/diff/1/trytond/trytond/wsgi.py#newcode155 trytond/trytond/wsgi.py:155: F401 'trytond' imported but unused https://codereview.tryton.org/66341002/diff/1/trytond/trytond/wsgi.py#newcode154 trytond/trytond/wsgi.py:154: E402 module level import not at ...
2 months, 1 week ago (2018-08-10 10:05:21 UTC) #1
ced
2 months, 1 week ago (2018-08-10 23:12:39 UTC) #2
pokoli
https://codereview.tryton.org/66341002/diff/1/tryton/tryton/rpc.py File tryton/tryton/rpc.py (right): https://codereview.tryton.org/66341002/diff/1/tryton/tryton/rpc.py#newcode126 tryton/tryton/rpc.py:126: notification.LISTEN = True notification should be set to False ...
2 months ago (2018-08-14 07:40:23 UTC) #3
ced
https://codereview.tryton.org/66341002/diff/1/tryton/tryton/notification.py File tryton/tryton/notification.py (right): https://codereview.tryton.org/66341002/diff/1/tryton/tryton/notification.py#newcode1 tryton/tryton/notification.py:1: # This file is part of Tryton. The COPYRIGHT ...
2 months ago (2018-08-14 08:37:02 UTC) #4
nicoe
https://codereview.tryton.org/66341002/diff/1/tryton/tryton/notification.py File tryton/tryton/notification.py (right): https://codereview.tryton.org/66341002/diff/1/tryton/tryton/notification.py#newcode1 tryton/tryton/notification.py:1: # This file is part of Tryton. The COPYRIGHT ...
2 months ago (2018-08-16 16:52:18 UTC) #5
nicoe
Fix remarks
2 months ago (2018-08-16 16:53:25 UTC) #6
reviewbot
https://codereview.tryton.org/66341002/diff/20001/trytond/trytond/wsgi.py#newcode155 trytond/trytond/wsgi.py:155: F401 'trytond' imported but unused https://codereview.tryton.org/66341002/diff/20001/trytond/trytond/wsgi.py#newcode154 trytond/trytond/wsgi.py:154: E402 module level import not at ...
2 months ago (2018-08-16 16:58:04 UTC) #7
ced
https://codereview.tryton.org/66341002/diff/1/tryton/tryton/rpc.py File tryton/tryton/rpc.py (right): https://codereview.tryton.org/66341002/diff/1/tryton/tryton/rpc.py#newcode39 tryton/tryton/rpc.py:39: return ':'.join('%x' % random.randint(0, 2 ** 32) for _ ...
2 months ago (2018-08-17 12:55:55 UTC) #8
nicoe
Use channels & fix remarks
1 month, 4 weeks ago (2018-08-20 12:31:46 UTC) #9
reviewbot
patch is not applicable URL: https://codereview.tryton.org/66341002
1 month, 4 weeks ago (2018-08-20 13:07:47 UTC) #10
nicoe
Update to tip
1 month, 4 weeks ago (2018-08-20 13:44:11 UTC) #11
reviewbot
https://codereview.tryton.org/66341002/diff/60001/trytond/trytond/wsgi.py#newcode155 trytond/trytond/wsgi.py:155: F401 'trytond' imported but unused https://codereview.tryton.org/66341002/diff/60001/trytond/trytond/wsgi.py#newcode154 trytond/trytond/wsgi.py:154: E402 module level import not at ...
1 month, 4 weeks ago (2018-08-20 14:05:15 UTC) #12
ced
There is a design flaw that prevents to use the bus on different machines because ...
1 month, 4 weeks ago (2018-08-21 10:35:52 UTC) #13
nicoe
https://codereview.tryton.org/66341002/diff/1/tryton/tryton/rpc.py File tryton/tryton/rpc.py (right): https://codereview.tryton.org/66341002/diff/1/tryton/tryton/rpc.py#newcode39 tryton/tryton/rpc.py:39: return ':'.join('%x' % random.randint(0, 2 ** 32) for _ ...
1 month, 3 weeks ago (2018-08-22 16:35:35 UTC) #14
nicoe
New queue implementation to support concurrent trytonds & fix remarks
1 month, 3 weeks ago (2018-08-22 16:42:18 UTC) #15
reviewbot
https://codereview.tryton.org/66341002/diff/80001/tryton/tryton/rpc.py#newcode3 tryton/tryton/rpc.py:3: F401 'threading' imported but unused https://codereview.tryton.org/66341002/diff/80001/trytond/trytond/wsgi.py#newcode155 trytond/trytond/wsgi.py:155: F401 'trytond' imported but unused https://codereview.tryton.org/66341002/diff/80001/trytond/trytond/wsgi.py#newcode154 ...
1 month, 3 weeks ago (2018-08-22 17:02:56 UTC) #16
ced
https://codereview.tryton.org/66341002/diff/60001/tryton/tryton/bus.py File tryton/tryton/bus.py (right): https://codereview.tryton.org/66341002/diff/60001/tryton/tryton/bus.py#newcode57 tryton/tryton/bus.py:57: } On 2018/08/22 16:35:33, nicoe wrote: > On 2018/08/21 ...
1 month, 3 weeks ago (2018-08-23 06:56:45 UTC) #17
nicoe
https://codereview.tryton.org/66341002/diff/60001/tryton/tryton/bus.py File tryton/tryton/bus.py (right): https://codereview.tryton.org/66341002/diff/60001/tryton/tryton/bus.py#newcode57 tryton/tryton/bus.py:57: } On 2018/08/23 06:56:45, ced wrote: > On 2018/08/22 ...
1 month, 3 weeks ago (2018-08-23 10:58:45 UTC) #18
nicoe
Use CONNECTION in the tryton listen call
1 month, 3 weeks ago (2018-08-23 11:00:12 UTC) #19
reviewbot
https://codereview.tryton.org/66341002/diff/100001/trytond/trytond/wsgi.py#newcode155 trytond/trytond/wsgi.py:155: F401 'trytond' imported but unused https://codereview.tryton.org/66341002/diff/100001/trytond/trytond/wsgi.py#newcode154 trytond/trytond/wsgi.py:154: E402 module level import not at ...
1 month, 3 weeks ago (2018-08-23 11:09:10 UTC) #20
ced
https://codereview.tryton.org/66341002/diff/100001/sao/src/bus.js File sao/src/bus.js (right): https://codereview.tryton.org/66341002/diff/100001/sao/src/bus.js#newcode17 sao/src/bus.js:17: return parts.join(''); I propose to use real uuid4 form ...
1 month, 3 weeks ago (2018-08-25 14:56:24 UTC) #21
nicoe
https://codereview.tryton.org/66341002/diff/100001/sao/src/bus.js File sao/src/bus.js (right): https://codereview.tryton.org/66341002/diff/100001/sao/src/bus.js#newcode17 sao/src/bus.js:17: return parts.join(''); On 2018/08/25 14:56:22, ced wrote: > I ...
1 month, 3 weeks ago (2018-08-27 20:50:20 UTC) #22
ced
https://codereview.tryton.org/66341002/diff/100001/tryton/tryton/common/common.py File tryton/tryton/common/common.py (right): https://codereview.tryton.org/66341002/diff/100001/tryton/tryton/common/common.py#newcode1152 tryton/tryton/common/common.py:1152: rpc_context['client'] = BUS_ID On 2018/08/27 20:50:18, nicoe wrote: > ...
1 month, 3 weeks ago (2018-08-28 07:12:06 UTC) #23
nicoe
https://codereview.tryton.org/66341002/diff/100001/tryton/tryton/common/common.py File tryton/tryton/common/common.py (right): https://codereview.tryton.org/66341002/diff/100001/tryton/tryton/common/common.py#newcode1152 tryton/tryton/common/common.py:1152: rpc_context['client'] = BUS_ID On 2018/08/28 07:12:05, ced wrote: > ...
1 month, 3 weeks ago (2018-08-28 10:57:47 UTC) #24
nicoe
Fix remarks
1 month, 3 weeks ago (2018-08-28 10:58:29 UTC) #25
reviewbot
https://codereview.tryton.org/66341002/diff/120001/trytond/trytond/wsgi.py#newcode155 trytond/trytond/wsgi.py:155: F401 'trytond' imported but unused https://codereview.tryton.org/66341002/diff/120001/trytond/trytond/wsgi.py#newcode154 trytond/trytond/wsgi.py:154: E402 module level import not at ...
1 month, 3 weeks ago (2018-08-28 11:04:38 UTC) #26
ced
https://codereview.tryton.org/66341002/diff/100001/trytond/trytond/bus.py File trytond/trytond/bus.py (right): https://codereview.tryton.org/66341002/diff/100001/trytond/trytond/bus.py#newcode153 trytond/trytond/bus.py:153: del cls._queues[database]['events'][channel] On 2018/08/28 10:57:47, nicoe wrote: > On ...
1 month, 3 weeks ago (2018-08-28 11:36:46 UTC) #27
ced
The bus connections should not stop if the server is stopped for awhile. https://codereview.tryton.org/66341002/diff/120001/sao/src/bus.js File ...
1 month, 3 weeks ago (2018-08-28 14:06:18 UTC) #28
nicoe
Fix remarks, fix corner case in the Message Queue, fix reconnection
1 month, 3 weeks ago (2018-08-28 16:51:56 UTC) #29
reviewbot
https://codereview.tryton.org/66341002/diff/140001/tryton/tryton/bus.py#newcode5 tryton/tryton/bus.py:5: F401 'http' imported but unused https://codereview.tryton.org/66341002/diff/140001/trytond/trytond/wsgi.py#newcode155 trytond/trytond/wsgi.py:155: F401 'trytond' imported but unused https://codereview.tryton.org/66341002/diff/140001/trytond/trytond/wsgi.py#newcode154 ...
1 month, 3 weeks ago (2018-08-28 16:55:13 UTC) #30
nicoe
Add MessageQueue testcase
1 month, 2 weeks ago (2018-08-28 21:09:04 UTC) #31
reviewbot
https://codereview.tryton.org/66341002/diff/160001/trytond/trytond/wsgi.py#newcode155 trytond/trytond/wsgi.py:155: F401 'trytond' imported but unused https://codereview.tryton.org/66341002/diff/160001/trytond/trytond/wsgi.py#newcode154 trytond/trytond/wsgi.py:154: E402 module level import not at ...
1 month, 2 weeks ago (2018-08-28 21:30:02 UTC) #32
ced
https://codereview.tryton.org/66341002/diff/160001/sao/src/bus.js File sao/src/bus.js (right): https://codereview.tryton.org/66341002/diff/160001/sao/src/bus.js#newcode43 sao/src/bus.js:43: Sao.Bus.listen(last_message); wait shoud be passed https://codereview.tryton.org/66341002/diff/160001/tryton/tryton/bus.py File tryton/tryton/bus.py (right): ...
1 month, 2 weeks ago (2018-08-29 06:39:04 UTC) #33
nicoe
https://codereview.tryton.org/66341002/diff/160001/sao/src/bus.js File sao/src/bus.js (right): https://codereview.tryton.org/66341002/diff/160001/sao/src/bus.js#newcode43 sao/src/bus.js:43: Sao.Bus.listen(last_message); On 2018/08/29 06:39:03, ced wrote: > wait shoud ...
1 month, 2 weeks ago (2018-08-29 10:05:46 UTC) #34
nicoe
1 month, 2 weeks ago (2018-08-29 10:05:52 UTC) #35
nicoe
fix remarks
1 month, 2 weeks ago (2018-08-29 10:07:20 UTC) #36
reviewbot
patch is not applicable URL: https://codereview.tryton.org/66341002
1 month, 2 weeks ago (2018-08-29 10:34:51 UTC) #37
ced
https://codereview.tryton.org/66341002/diff/160001/tryton/tryton/bus.py File tryton/tryton/bus.py (right): https://codereview.tryton.org/66341002/diff/160001/tryton/tryton/bus.py#newcode59 tryton/tryton/bus.py:59: ConnectionResetError, URLError, socket.timeout) as error: On 2018/08/29 10:05:46, nicoe ...
1 month, 2 weeks ago (2018-08-29 10:56:17 UTC) #38
nicoe
https://codereview.tryton.org/66341002/diff/180001/sao/src/bus.js File sao/src/bus.js (right): https://codereview.tryton.org/66341002/diff/180001/sao/src/bus.js#newcode47 sao/src/bus.js:47: if ((error === "timeout") || (error === "")) { ...
1 month, 2 weeks ago (2018-08-29 13:25:20 UTC) #39
nicoe
fix exception handling
1 month, 2 weeks ago (2018-08-29 13:25:27 UTC) #40
reviewbot
patch is not applicable URL: https://codereview.tryton.org/66341002
1 month, 2 weeks ago (2018-08-29 13:30:42 UTC) #41
ced
https://codereview.tryton.org/66341002/diff/200001/sao/src/bus.js File sao/src/bus.js (right): https://codereview.tryton.org/66341002/diff/200001/sao/src/bus.js#newcode31 sao/src/bus.js:31: timeout: 10 * 60 * 1000, It should be ...
1 month, 2 weeks ago (2018-08-29 16:18:55 UTC) #42
nicoe
fix remarks
1 month, 2 weeks ago (2018-08-29 16:49:50 UTC) #43
reviewbot
patch is not applicable URL: https://codereview.tryton.org/66341002
1 month, 2 weeks ago (2018-08-29 16:58:40 UTC) #44
nicoe
update to tip
1 month, 2 weeks ago (2018-08-29 17:34:45 UTC) #45
ced
On 2018/08/29 16:58:40, reviewbot wrote: > patch is not applicable > URL: https://codereview.tryton.org/66341002 Please fix.
1 month, 2 weeks ago (2018-08-29 17:37:30 UTC) #46
ced
https://codereview.tryton.org/66341002/diff/220001/tryton/tryton/bus.py File tryton/tryton/bus.py (right): https://codereview.tryton.org/66341002/diff/220001/tryton/tryton/bus.py#newcode56 tryton/tryton/bus.py:56: except HTTPError as error: I think this should be ...
1 month, 2 weeks ago (2018-08-29 17:37:37 UTC) #47
nicoe
Do not handle HTTPError separately
1 month, 2 weeks ago (2018-08-29 17:52:14 UTC) #48
reviewbot
https://codereview.tryton.org/66341002/diff/260001/trytond/trytond/wsgi.py#newcode155 trytond/trytond/wsgi.py:155: F401 'trytond' imported but unused https://codereview.tryton.org/66341002/diff/260001/trytond/trytond/wsgi.py#newcode154 trytond/trytond/wsgi.py:154: E402 module level import not at ...
1 month, 2 weeks ago (2018-08-29 17:58:25 UTC) #49
ced
LGTM
1 month, 2 weeks ago (2018-08-29 18:06:46 UTC) #50
rietveld-bot_tryton.org
New changeset 24d7407ed47a by Nicolas ?vrard in branch 'default': Add bus management https://hg.tryton.org/sao/rev/24d7407ed47a
1 month, 2 weeks ago (2018-08-30 09:16:05 UTC) #51
rietveld-bot_tryton.org
New changeset dfac5ee59e60 by Nicolas ?vrard in branch 'default': Add bus management https://hg.tryton.org/tryton/rev/dfac5ee59e60
1 month, 2 weeks ago (2018-08-30 09:16:09 UTC) #52
rietveld-bot_tryton.org
New changeset 6d62f513f177 by Nicolas ?vrard in branch 'default': Add bus management https://hg.tryton.org/trytond/rev/6d62f513f177
1 month, 2 weeks ago (2018-08-30 09:16:11 UTC) #53
rietveld-bot_tryton.org
1 month, 2 weeks ago (2018-08-30 09:16:14 UTC) #54
New changeset 1decbef5d7ed by Nicolas ?vrard in branch 'default':
Add bus management
https://hg.tryton.org/tryton-env/rev/1decbef5d7ed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766