Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2159)

Issue 66441002: tryton-env: Add day view on calendar (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 2 weeks ago by pokoli
Modified:
1 month, 3 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add changelog #

Patch Set 3 : Re-upload #

Total comments: 3

Patch Set 4 : Fix ced's comments #

Total comments: 1

Patch Set 5 : Format using date format from the context #

Patch Set 6 : Update to tip #

Total comments: 3

Patch Set 7 : Fix remarks and update issues #

Total comments: 1

Patch Set 8 : Do not allow to customize day label #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -8 lines) Patch
M sao/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M sao/src/view/calendar.js View 1 2 3 4 5 6 2 chunks +12 lines, -1 line 0 comments Download
M tryton/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/calendar_gtk/calendar_.py View 2 1 chunk +3 lines, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py View 1 2 3 4 5 6 7 4 chunks +20 lines, -5 lines 0 comments Download
M trytond/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M trytond/doc/topics/views/index.rst View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M trytond/trytond/ir/ui/calendar.rnc View 2 1 chunk +2 lines, -1 line 0 comments Download
M trytond/trytond/ir/ui/calendar.rng View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26
pokoli
7 months, 2 weeks ago (2018-10-08 09:52:28 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/66441002
7 months, 2 weeks ago (2018-10-08 10:06:51 UTC) #2
pokoli
Add changelog
7 months, 2 weeks ago (2018-10-08 10:08:09 UTC) #3
pokoli
Re-upload
7 months, 2 weeks ago (2018-10-08 10:08:34 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/66441002
7 months, 2 weeks ago (2018-10-08 10:31:49 UTC) #5
ced
https://codereview.tryton.org/66441002/diff/40001/tryton/CHANGELOG File tryton/CHANGELOG (right): https://codereview.tryton.org/66441002/diff/40001/tryton/CHANGELOG#newcode1 tryton/CHANGELOG:1: * Add day view on calendar Missing dependency to ...
7 months, 2 weeks ago (2018-10-09 08:56:18 UTC) #6
pokoli
Fix ced's comments
7 months, 1 week ago (2018-10-15 14:15:06 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/66441002
7 months, 1 week ago (2018-10-15 14:27:07 UTC) #8
ced
We will need to wait a release of goocalendar before commit it. https://codereview.tryton.org/66441002/diff/60001/tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py File tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py ...
7 months ago (2018-10-23 19:00:03 UTC) #9
pokoli
Format using date format from the context
7 months ago (2018-10-25 12:50:43 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/66441002
7 months ago (2018-10-25 13:00:20 UTC) #11
ced
LGTM but we have to wait a release of goocalendar.
7 months ago (2018-10-25 13:21:14 UTC) #12
ced
On 2018/10/25 13:21:14, ced wrote: > LGTM but we have to wait a release of ...
2 months, 2 weeks ago (2019-03-10 16:26:55 UTC) #13
pokoli
Update to tip
2 months, 1 week ago (2019-03-15 15:44:12 UTC) #14
reviewbot
https://codereview.tryton.org/66441002/diff/251131002/tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py#newcode113 tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py:113: F821 undefined name 'gtk' https://codereview.tryton.org/66441002/diff/251131002/tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py#newcode117 tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py:117: F821 undefined name 'gtk' https://codereview.tryton.org/66441002/diff/251131002/tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py#newcode118 tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py:118: F821 ...
2 months, 1 week ago (2019-03-15 16:15:25 UTC) #15
ced
I think trytond should also have a CHANGELOG entry. https://codereview.tryton.org/66441002/diff/251131002/tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py File tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py (right): https://codereview.tryton.org/66441002/diff/251131002/tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py#newcode113 tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py:113: ...
2 months ago (2019-03-22 15:22:26 UTC) #16
pokoli
Fix remarks and update issues
1 month, 4 weeks ago (2019-03-25 11:05:53 UTC) #17
reviewbot
patch is not applicable URL: https://codereview.tryton.org/66441002
1 month, 4 weeks ago (2019-03-25 11:24:19 UTC) #18
ced
https://codereview.tryton.org/66441002/diff/263161002/tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py File tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py (right): https://codereview.tryton.org/66441002/diff/263161002/tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py#newcode162 tryton/tryton/gui/window/view_form/view/calendar_gtk/toolbar.py:162: 'date_format', '%x') As we can not customize the month ...
1 month, 3 weeks ago (2019-03-27 22:03:43 UTC) #19
pokoli
Do not allow to customize day label
1 month, 3 weeks ago (2019-03-28 08:57:21 UTC) #20
reviewbot
flake8 OK URL: https://codereview.tryton.org/66441002
1 month, 3 weeks ago (2019-03-28 09:11:38 UTC) #21
ced
LGTM
1 month, 3 weeks ago (2019-03-28 09:42:55 UTC) #22
rietveld-bot_tryton.org
New changeset f2c69d6d24bc by Sergi Almacellas Abellana in branch 'default': Add day view on calendar ...
1 month, 3 weeks ago (2019-03-28 11:27:19 UTC) #23
rietveld-bot_tryton.org
New changeset b553daa13fce by Sergi Almacellas Abellana in branch 'default': Add day view on calendar ...
1 month, 3 weeks ago (2019-03-28 11:27:21 UTC) #24
rietveld-bot_tryton.org
New changeset 6bee5ded03ca by Sergi Almacellas Abellana in branch 'default': Add day view on calendar ...
1 month, 3 weeks ago (2019-03-28 11:27:23 UTC) #25
rietveld-bot_tryton.org
1 month, 3 weeks ago (2019-03-28 11:27:26 UTC) #26
New changeset 3c42356e363a by Sergi Almacellas Abellana in branch 'default':
Add day view on calendar
https://hg.tryton.org/tryton-env/rev/3c42356e363a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766