Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(90)

Issue 66501002: tryton-env: Add default name ordering on referential models (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by pokoli
Modified:
1 month, 2 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove changelogs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M modules/account/move.py View 1 chunk +5 lines, -0 lines 0 comments Download
M modules/account_dunning/dunning.py View 1 chunk +5 lines, -0 lines 0 comments Download
M modules/account_invoice/invoice.py View 1 chunk +5 lines, -0 lines 0 comments Download
M modules/account_payment/payment.py View 1 chunk +5 lines, -0 lines 0 comments Download
M modules/account_statement/journal.py View 1 chunk +1 line, -0 lines 0 comments Download
M modules/sale_subscription/recurrence.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16
pokoli
2 months, 1 week ago (2019-01-07 10:25:00 UTC) #1
reviewbot
https://codereview.tryton.org/66501002/diff/1/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/66501002/diff/1/modules/account/move.py#newcode413 modules/account/move.py:413: E731 do not assign ...
2 months, 1 week ago (2019-01-07 10:43:11 UTC) #2
ced
I think "… on some models" could be better. https://codereview.tryton.org/66501002/diff/1/modules/account/CHANGELOG File modules/account/CHANGELOG (right): https://codereview.tryton.org/66501002/diff/1/modules/account/CHANGELOG#newcode1 modules/account/CHANGELOG:1: ...
2 months, 1 week ago (2019-01-07 20:50:11 UTC) #3
pokoli
Remove changelogs
2 months, 1 week ago (2019-01-08 17:59:21 UTC) #4
pokoli
On 2019/01/07 20:50:11, ced wrote: > I think "… on some models" could be better. ...
2 months, 1 week ago (2019-01-08 17:59:41 UTC) #5
ced
On 2019/01/08 17:59:41, pokoli wrote: > On 2019/01/07 20:50:11, ced wrote: > > I think ...
2 months, 1 week ago (2019-01-08 18:06:49 UTC) #6
reviewbot
https://codereview.tryton.org/66501002/diff/20001/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/66501002/diff/20001/modules/account/move.py#newcode413 modules/account/move.py:413: E731 do not assign ...
2 months, 1 week ago (2019-01-08 18:11:41 UTC) #7
pokoli
On 2019/01/08 18:06:49, ced wrote: > On 2019/01/08 17:59:41, pokoli wrote: > > On 2019/01/07 ...
2 months, 1 week ago (2019-01-10 09:46:00 UTC) #8
ced
LGTM
2 months ago (2019-01-15 14:09:18 UTC) #9
rietveld-bot_tryton.org
New changeset d50e0560d168 by Sergi Almacellas Abellana in branch 'default': Add default name ordering on ...
1 month, 2 weeks ago (2019-01-30 10:59:51 UTC) #10
rietveld-bot_tryton.org
New changeset 328e935cb271 by Sergi Almacellas Abellana in branch 'default': Add default name ordering on ...
1 month, 2 weeks ago (2019-01-30 10:59:58 UTC) #11
rietveld-bot_tryton.org
New changeset 285ab8fce27d by Sergi Almacellas Abellana in branch 'default': Add default name ordering on ...
1 month, 2 weeks ago (2019-01-30 11:00:03 UTC) #12
rietveld-bot_tryton.org
New changeset ec0d07e1249a by Sergi Almacellas Abellana in branch 'default': Add default name ordering on ...
1 month, 2 weeks ago (2019-01-30 11:00:06 UTC) #13
rietveld-bot_tryton.org
New changeset 38674f99dfd1 by Sergi Almacellas Abellana in branch 'default': Add default name ordering on ...
1 month, 2 weeks ago (2019-01-30 11:00:09 UTC) #14
rietveld-bot_tryton.org
New changeset bb09b8eeec2e by Sergi Almacellas Abellana in branch 'default': Add default name ordering on ...
1 month, 2 weeks ago (2019-01-30 11:00:16 UTC) #15
rietveld-bot_tryton.org
1 month, 2 weeks ago (2019-01-30 11:00:24 UTC) #16
New changeset 98c4eeffd335 by Sergi Almacellas Abellana in branch 'default':
Add default name ordering on referential models
https://hg.tryton.org/tryton-env/rev/98c4eeffd335
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766