Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(108)

Issue 66541002: stock: Do not pick product at the destination location (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by ced
Modified:
2 weeks, 5 days ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

It is forbidden to create move with the same source and destination locations. To avoid this case, we remove the destination location from the quantities to pick. issue7856

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M move.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/test_stock.py View 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 9
ced
1 month, 1 week ago (2019-02-05 17:40:56 UTC) #1
reviewbot
https://codereview.tryton.org/66541002/diff/1/move.py#newcode1049 move.py:1049: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 month, 1 week ago (2019-02-05 17:43:22 UTC) #2
pokoli
https://codereview.tryton.org/66541002/diff/1/move.py File move.py (right): https://codereview.tryton.org/66541002/diff/1/move.py#newcode884 move.py:884: location_qties.pop(move.to_location, None) I think it's worth to add a ...
1 month, 1 week ago (2019-02-06 11:02:01 UTC) #3
ced
Add comment
1 month, 1 week ago (2019-02-06 11:06:31 UTC) #4
reviewbot
https://codereview.tryton.org/66541002/diff/20001/move.py#newcode1050 move.py:1050: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 month, 1 week ago (2019-02-06 11:09:18 UTC) #5
pokoli
LGTM
1 month, 1 week ago (2019-02-06 11:14:24 UTC) #6
rietveld-bot_tryton.org
New changeset d57f046484b8 by Cédric Krier in branch 'default': Do not pick product at the ...
1 month ago (2019-02-18 17:36:06 UTC) #7
rietveld-bot_tryton.org
New changeset 20e64d915b37 by Cédric Krier in branch 'default': Do not pick product at the ...
1 month ago (2019-02-18 17:36:16 UTC) #8
rietveld-bot_tryton.org
2 weeks, 5 days ago (2019-02-28 22:22:25 UTC) #9
New changeset cc1828be09ec by Cédric Krier in branch '5.0':
Do not pick product at the destination location
https://hg.tryton.org/modules/stock/rev/cc1828be09ec


New changeset 4fe5c08470ee by Cédric Krier in branch '4.8':
Do not pick product at the destination location
https://hg.tryton.org/modules/stock/rev/4fe5c08470ee


New changeset 954b33c292fa by Cédric Krier in branch '4.6':
Do not pick product at the destination location
https://hg.tryton.org/modules/stock/rev/954b33c292fa


New changeset 743c9742e31e by Cédric Krier in branch '4.4':
Do not pick product at the destination location
https://hg.tryton.org/modules/stock/rev/743c9742e31e


New changeset ee3cab25941a by Cédric Krier in branch '4.2':
Do not pick product at the destination location
https://hg.tryton.org/modules/stock/rev/ee3cab25941a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766