Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 68381002: tryton-env: Clean active_* keys from context when executing an action (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by pokoli
Modified:
2 weeks, 5 days ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

As the values may be already present on the context they should be cleared in order to correctly evaluate action domains issue7839

Patch Set 1 #

Total comments: 8

Patch Set 2 : Do not update ctx with context #

Patch Set 3 : Clean active_* keys from context when executing an action #

Patch Set 4 : Ensure context is always an object before deleting it's keys #

Total comments: 3

Patch Set 5 : Fix remarks #

Total comments: 1

Patch Set 6 : Copy context in else block #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M sao/src/action.js View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download
M tryton/tryton/action/main.py View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 24
pokoli
3 months, 1 week ago (2018-12-10 19:44:06 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/68381002
3 months, 1 week ago (2018-12-10 20:16:06 UTC) #2
ced
https://codereview.tryton.org/68381002/diff/1/tryton/tryton/action/main.py File tryton/tryton/action/main.py (right): https://codereview.tryton.org/68381002/diff/1/tryton/tryton/action/main.py#newcode117 tryton/tryton/action/main.py:117: 'active_ids': data.get('ids', []), I do not understand how such ...
3 months, 1 week ago (2018-12-10 21:23:11 UTC) #3
pokoli
Do not update ctx with context
3 months, 1 week ago (2018-12-11 11:30:58 UTC) #4
pokoli
https://codereview.tryton.org/68381002/diff/1/tryton/tryton/action/main.py File tryton/tryton/action/main.py (right): https://codereview.tryton.org/68381002/diff/1/tryton/tryton/action/main.py#newcode117 tryton/tryton/action/main.py:117: 'active_ids': data.get('ids', []), On 2018/12/10 21:23:11, ced wrote: > ...
3 months, 1 week ago (2018-12-11 11:31:02 UTC) #5
ced
https://codereview.tryton.org/68381002/diff/1/tryton/tryton/action/main.py File tryton/tryton/action/main.py (right): https://codereview.tryton.org/68381002/diff/1/tryton/tryton/action/main.py#newcode117 tryton/tryton/action/main.py:117: 'active_ids': data.get('ids', []), On 2018/12/11 11:31:01, pokoli wrote: > ...
3 months, 1 week ago (2018-12-11 11:45:44 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/68381002
3 months, 1 week ago (2018-12-11 11:47:33 UTC) #7
pokoli
https://codereview.tryton.org/68381002/diff/1/tryton/tryton/action/main.py File tryton/tryton/action/main.py (right): https://codereview.tryton.org/68381002/diff/1/tryton/tryton/action/main.py#newcode117 tryton/tryton/action/main.py:117: 'active_ids': data.get('ids', []), On 2018/12/11 11:45:44, ced wrote: > ...
3 months, 1 week ago (2018-12-11 12:18:47 UTC) #8
pokoli
Clean active_* keys from context when executing an action
1 month, 2 weeks ago (2019-01-30 11:31:55 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/68381002
1 month, 2 weeks ago (2019-01-30 11:49:24 UTC) #10
pokoli
Ensure context is always an object before deleting it's keys
1 month, 2 weeks ago (2019-01-30 12:07:40 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/68381002
1 month, 2 weeks ago (2019-01-30 12:18:24 UTC) #12
ced
https://codereview.tryton.org/68381002/diff/60001/sao/src/action.js File sao/src/action.js (right): https://codereview.tryton.org/68381002/diff/60001/sao/src/action.js#newcode11 sao/src/action.js:11: if (context === undefined || context === null) { ...
1 month, 1 week ago (2019-02-05 08:44:51 UTC) #13
pokoli
Fix remarks
1 month, 1 week ago (2019-02-06 16:12:29 UTC) #14
reviewbot
flake8 OK URL: https://codereview.tryton.org/68381002
1 month, 1 week ago (2019-02-06 16:17:59 UTC) #15
ced
https://codereview.tryton.org/68381002/diff/80001/tryton/tryton/action/main.py File tryton/tryton/action/main.py (right): https://codereview.tryton.org/68381002/diff/80001/tryton/tryton/action/main.py#newcode82 tryton/tryton/action/main.py:82: context = context.copy() Why not do in the else ...
1 month, 1 week ago (2019-02-06 18:36:05 UTC) #16
pokoli
Copy context in else block
1 month, 1 week ago (2019-02-07 07:54:55 UTC) #17
reviewbot
flake8 OK URL: https://codereview.tryton.org/68381002
1 month, 1 week ago (2019-02-07 08:15:07 UTC) #18
ced
LGTM
1 month, 1 week ago (2019-02-07 08:33:29 UTC) #19
rietveld-bot_tryton.org
New changeset f70f3f848279 by Sergi Almacellas Abellana in branch 'default': Clean active_* keys from context ...
3 weeks, 5 days ago (2019-02-22 18:36:26 UTC) #20
rietveld-bot_tryton.org
New changeset b5a32fb596ff by Sergi Almacellas Abellana in branch 'default': Clean active_* keys from context ...
3 weeks, 5 days ago (2019-02-22 18:36:29 UTC) #21
rietveld-bot_tryton.org
New changeset a18ef54ca1c6 by Sergi Almacellas Abellana in branch 'default': Clean active_* keys from context ...
3 weeks, 5 days ago (2019-02-22 18:36:31 UTC) #22
rietveld-bot_tryton.org
New changeset 84575cb34500 by Sergi Almacellas Abellana in branch '5.0': Clean active_* keys from context ...
2 weeks, 5 days ago (2019-02-28 22:22:41 UTC) #23
rietveld-bot_tryton.org
2 weeks, 5 days ago (2019-02-28 22:22:50 UTC) #24
New changeset 95ebda9328b0 by Sergi Almacellas Abellana in branch '5.0':
Clean active_* keys from context when executing an action
https://hg.tryton.org/tryton/rev/95ebda9328b0


New changeset 731cf728161f by Sergi Almacellas Abellana in branch '4.8':
Clean active_* keys from context when executing an action
https://hg.tryton.org/tryton/rev/731cf728161f


New changeset de58bed0ec29 by Sergi Almacellas Abellana in branch '4.6':
Clean active_* keys from context when executing an action
https://hg.tryton.org/tryton/rev/de58bed0ec29


New changeset fb7c6e651275 by Sergi Almacellas Abellana in branch '4.4':
Clean active_* keys from context when executing an action
https://hg.tryton.org/tryton/rev/fb7c6e651275


New changeset c8621f2a3ac7 by Sergi Almacellas Abellana in branch '4.2':
Clean active_* keys from context when executing an action
https://hg.tryton.org/tryton/rev/c8621f2a3ac7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766