Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(168)

Issue 68401002: tryton-env: Merge account kind and account type

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 4 days ago by ced
Modified:
5 days, 14 hours ago
Reviewers:
dave, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add assets and rename fixed_asset & add account_be #

Patch Set 3 : Add account_fr, remove payble/receivable constraint on tax for balance #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4710 lines, -6817 lines) Patch
M modules/account/CHANGELOG View 2 1 chunk +2 lines, -0 lines 0 comments Download
M modules/account/account.py View 1 2 26 chunks +270 lines, -140 lines 1 comment Download
M modules/account/account.xml View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M modules/account/configuration.py View 2 3 chunks +4 lines, -4 lines 0 comments Download
M modules/account/doc/index.rst View 1 2 2 chunks +3 lines, -20 lines 0 comments Download
M modules/account/fiscalyear.py View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M modules/account/journal.py View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M modules/account/message.xml View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M modules/account/minimal_chart.xml View 1 2 23 chunks +26 lines, -17 lines 0 comments Download
M modules/account/minimal_chart_bg.xml View 1 2 23 chunks +49 lines, -17 lines 0 comments Download
M modules/account/minimal_chart_ca.xml View 1 2 23 chunks +49 lines, -17 lines 0 comments Download
M modules/account/minimal_chart_de.xml View 1 2 23 chunks +49 lines, -17 lines 0 comments Download
M modules/account/minimal_chart_en.xml View 1 2 23 chunks +26 lines, -17 lines 0 comments Download
M modules/account/minimal_chart_es.xml View 1 2 23 chunks +49 lines, -17 lines 0 comments Download
M modules/account/minimal_chart_fr.xml View 1 2 23 chunks +26 lines, -17 lines 0 comments Download
M modules/account/minimal_chart_nl.xml View 1 2 23 chunks +49 lines, -17 lines 0 comments Download
M modules/account/minimal_chart_pt.xml View 1 2 23 chunks +27 lines, -18 lines 0 comments Download
M modules/account/minimal_chart_ru.xml View 1 2 23 chunks +49 lines, -17 lines 0 comments Download
M modules/account/minimal_chart_sl.xml View 1 2 23 chunks +49 lines, -17 lines 0 comments Download
M modules/account/move.py View 1 2 7 chunks +26 lines, -16 lines 0 comments Download
M modules/account/move.xml View 2 3 chunks +3 lines, -3 lines 0 comments Download
M modules/account/move_template.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M modules/account/party.py View 1 2 8 chunks +17 lines, -10 lines 0 comments Download
M modules/account/tax.py View 1 2 3 chunks +16 lines, -6 lines 0 comments Download
M modules/account/tests/test_account.py View 2 8 chunks +17 lines, -26 lines 0 comments Download
M modules/account/tests/tools.py View 2 1 chunk +20 lines, -12 lines 0 comments Download
M modules/account/view/account_form.xml View 1 2 1 chunk +18 lines, -16 lines 0 comments Download
M modules/account/view/account_template_form.xml View 1 2 1 chunk +8 lines, -7 lines 0 comments Download
M modules/account/view/account_type_form.xml View 1 2 1 chunk +21 lines, -11 lines 0 comments Download
M modules/account/view/account_type_template_form.xml View 1 2 1 chunk +18 lines, -9 lines 0 comments Download
M modules/account_asset/CHANGELOG View 2 1 chunk +2 lines, -0 lines 0 comments Download
M modules/account_asset/__init__.py View 2 1 chunk +2 lines, -0 lines 0 comments Download
M modules/account_asset/account.py View 1 2 2 chunks +29 lines, -4 lines 0 comments Download
M modules/account_asset/account.xml View 2 1 chunk +12 lines, -0 lines 0 comments Download
M modules/account_asset/asset.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M modules/account_asset/invoice.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M modules/account_asset/minimal_chart.xml View 1 2 3 chunks +23 lines, -11 lines 0 comments Download
M modules/account_asset/minimal_chart_bg.xml View 1 2 3 chunks +23 lines, -7 lines 0 comments Download
M modules/account_asset/minimal_chart_ca.xml View 1 2 3 chunks +23 lines, -7 lines 0 comments Download
M modules/account_asset/minimal_chart_de.xml View 1 2 3 chunks +23 lines, -7 lines 0 comments Download
M modules/account_asset/minimal_chart_en.xml View 1 2 3 chunks +23 lines, -7 lines 0 comments Download
M modules/account_asset/minimal_chart_es.xml View 1 2 3 chunks +23 lines, -7 lines 0 comments Download
M modules/account_asset/minimal_chart_fr.xml View 1 2 3 chunks +23 lines, -7 lines 0 comments Download
M modules/account_asset/minimal_chart_nl.xml View 1 2 3 chunks +23 lines, -7 lines 0 comments Download
M modules/account_asset/minimal_chart_pt.xml View 1 2 3 chunks +21 lines, -7 lines 0 comments Download
M modules/account_asset/minimal_chart_ru.xml View 1 2 3 chunks +23 lines, -7 lines 0 comments Download
M modules/account_asset/minimal_chart_sl.xml View 1 2 3 chunks +23 lines, -7 lines 0 comments Download
M modules/account_asset/product.py View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M modules/account_asset/tests/tools.py View 1 2 1 chunk +9 lines, -13 lines 0 comments Download
A modules/account_asset/view/account_type_form.xml View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M modules/account_be/account_be.xml View 1 2 627 chunks +481 lines, -1151 lines 0 comments Download
M modules/account_be/account_be_fr.xml View 1 2 627 chunks +487 lines, -1157 lines 0 comments Download
M modules/account_be/account_be_nl.xml View 1 2 627 chunks +487 lines, -1157 lines 0 comments Download
M modules/account_be/tryton.cfg View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M modules/account_credit_limit/tests/test_account_credit_limit.py View 2 1 chunk +2 lines, -2 lines 0 comments Download
M modules/account_deposit/CHANGELOG View 2 1 chunk +2 lines, -0 lines 0 comments Download
M modules/account_deposit/__init__.py View 2 1 chunk +3 lines, -3 lines 0 comments Download
M modules/account_deposit/account.py View 1 2 1 chunk +24 lines, -15 lines 0 comments Download
A modules/account_deposit/account.xml View 2 1 chunk +18 lines, -0 lines 0 comments Download
M modules/account_deposit/invoice.py View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M modules/account_deposit/minimal_chart.xml View 1 2 1 chunk +25 lines, -28 lines 0 comments Download
M modules/account_deposit/minimal_chart_bg.xml View 1 2 3 chunks +10 lines, -8 lines 0 comments Download
M modules/account_deposit/minimal_chart_ca.xml View 1 2 1 chunk +10 lines, -8 lines 0 comments Download
M modules/account_deposit/minimal_chart_de.xml View 1 2 1 chunk +10 lines, -8 lines 0 comments Download
M modules/account_deposit/minimal_chart_en.xml View 1 2 3 chunks +9 lines, -7 lines 0 comments Download
M modules/account_deposit/minimal_chart_es.xml View 1 2 2 chunks +10 lines, -8 lines 0 comments Download
M modules/account_deposit/minimal_chart_fr.xml View 1 2 2 chunks +10 lines, -8 lines 0 comments Download
M modules/account_deposit/minimal_chart_nl.xml View 1 2 2 chunks +10 lines, -8 lines 0 comments Download
M modules/account_deposit/minimal_chart_pt.xml View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M modules/account_deposit/minimal_chart_ru.xml View 1 2 3 chunks +10 lines, -8 lines 0 comments Download
M modules/account_deposit/minimal_chart_sl.xml View 1 2 3 chunks +10 lines, -8 lines 0 comments Download
M modules/account_deposit/party.py View 1 2 6 chunks +16 lines, -9 lines 0 comments Download
M modules/account_deposit/tests/tools.py View 2 1 chunk +1 line, -1 line 0 comments Download
M modules/account_deposit/tryton.cfg View 2 1 chunk +1 line, -0 lines 0 comments Download
A modules/account_deposit/view/account_type_form.xml View 2 1 chunk +9 lines, -0 lines 0 comments Download
M modules/account_dunning/dunning.py View 2 2 chunks +2 lines, -2 lines 0 comments Download
M modules/account_dunning_letter/dunning.py View 2 1 chunk +1 line, -1 line 0 comments Download
M modules/account_fr/account.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M modules/account_fr/account_fr.xml View 1 2 25 chunks +824 lines, -2265 lines 0 comments Download
M modules/account_fr/tests/FEC.csv View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M modules/account_fr/tests/FEC-previous.csv View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M modules/account_fr/tests/tools.py View 1 2 1 chunk +22 lines, -10 lines 0 comments Download
M modules/account_invoice/invoice.py View 1 2 5 chunks +20 lines, -17 lines 0 comments Download
M modules/account_payment/account.py View 1 2 4 chunks +21 lines, -16 lines 0 comments Download
M modules/account_payment/account.xml View 2 1 chunk +1 line, -1 line 0 comments Download
M modules/account_payment/payment.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M modules/account_payment_clearing/payment.py View 2 1 chunk +5 lines, -1 line 0 comments Download
M modules/account_product/account.py View 2 1 chunk +2 lines, -2 lines 0 comments Download
M modules/account_product/configuration.py View 2 2 chunks +4 lines, -4 lines 0 comments Download
M modules/account_product/product.py View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M modules/account_product/tests/test_account_product.py View 2 1 chunk +1 line, -1 line 0 comments Download
M modules/account_statement/journal.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M modules/account_statement/statement.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M modules/account_stock_anglo_saxon/CHANGELOG View 2 1 chunk +2 lines, -0 lines 0 comments Download
M modules/account_stock_anglo_saxon/minimal_chart.xml View 2 1 chunk +0 lines, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/minimal_chart_bg.xml View 2 1 chunk +1 line, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/minimal_chart_ca.xml View 2 1 chunk +1 line, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/minimal_chart_de.xml View 2 1 chunk +1 line, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/minimal_chart_en.xml View 2 1 chunk +1 line, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/minimal_chart_es.xml View 2 1 chunk +1 line, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/minimal_chart_fr.xml View 2 1 chunk +1 line, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/minimal_chart_nl.xml View 2 1 chunk +1 line, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/minimal_chart_pt.xml View 2 1 chunk +0 lines, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/minimal_chart_ru.xml View 2 1 chunk +1 line, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/minimal_chart_sl.xml View 2 1 chunk +1 line, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/product.py View 2 2 chunks +2 lines, -2 lines 0 comments Download
M modules/account_stock_anglo_saxon/tests/tools.py View 2 1 chunk +2 lines, -2 lines 0 comments Download
M modules/account_stock_continental/CHANGELOG View 2 1 chunk +2 lines, -0 lines 0 comments Download
M modules/account_stock_continental/minimal_chart.xml View 2 6 chunks +23 lines, -21 lines 0 comments Download
M modules/account_stock_continental/minimal_chart_bg.xml View 2 6 chunks +29 lines, -18 lines 0 comments Download
M modules/account_stock_continental/minimal_chart_ca.xml View 2 6 chunks +29 lines, -18 lines 0 comments Download
M modules/account_stock_continental/minimal_chart_de.xml View 2 6 chunks +29 lines, -18 lines 0 comments Download
M modules/account_stock_continental/minimal_chart_en.xml View 2 6 chunks +29 lines, -18 lines 0 comments Download
M modules/account_stock_continental/minimal_chart_es.xml View 2 6 chunks +29 lines, -18 lines 0 comments Download
M modules/account_stock_continental/minimal_chart_fr.xml View 2 6 chunks +29 lines, -18 lines 0 comments Download
M modules/account_stock_continental/minimal_chart_nl.xml View 2 6 chunks +29 lines, -18 lines 0 comments Download
M modules/account_stock_continental/minimal_chart_pt.xml View 2 6 chunks +23 lines, -18 lines 0 comments Download
M modules/account_stock_continental/minimal_chart_ru.xml View 2 6 chunks +29 lines, -18 lines 0 comments Download
M modules/account_stock_continental/minimal_chart_sl.xml View 2 6 chunks +29 lines, -18 lines 0 comments Download
M modules/account_stock_continental/product.py View 1 2 7 chunks +16 lines, -10 lines 0 comments Download
M modules/account_stock_continental/tests/tools.py View 2 1 chunk +1 line, -1 line 0 comments Download
M modules/account_tax_cash/account.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M modules/analytic_account/CHANGELOG View 2 1 chunk +2 lines, -0 lines 0 comments Download
M modules/analytic_account/account.py View 1 2 5 chunks +4 lines, -11 lines 0 comments Download
M modules/analytic_account/line.py View 1 2 1 chunk +1 line, -10 lines 0 comments Download
M modules/analytic_account/tests/test_analytic_account.py View 2 2 chunks +6 lines, -6 lines 0 comments Download
M modules/analytic_account/view/account_form.xml View 2 1 chunk +1 line, -2 lines 0 comments Download
M modules/commission_waiting/commission.py View 2 1 chunk +0 lines, -1 line 0 comments Download
M modules/purchase/tests/test_purchase.py View 2 1 chunk +2 lines, -2 lines 0 comments Download
M modules/sale/tests/test_sale.py View 2 1 chunk +2 lines, -2 lines 0 comments Download
M modules/sale_advance_payment/CHANGELOG View 2 1 chunk +2 lines, -0 lines 0 comments Download
M modules/sale_advance_payment/__init__.py View 2 1 chunk +2 lines, -0 lines 0 comments Download
M modules/sale_advance_payment/account.py View 1 2 2 chunks +36 lines, -1 line 0 comments Download
A modules/sale_advance_payment/account.xml View 2 1 chunk +18 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/minimal_chart.xml View 2 1 chunk +38 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/minimal_chart_bg.xml View 2 1 chunk +38 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/minimal_chart_ca.xml View 2 1 chunk +38 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/minimal_chart_de.xml View 2 1 chunk +38 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/minimal_chart_en.xml View 2 1 chunk +38 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/minimal_chart_es.xml View 2 1 chunk +38 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/minimal_chart_fr.xml View 2 1 chunk +38 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/minimal_chart_nl.xml View 2 1 chunk +38 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/minimal_chart_pt.xml View 2 1 chunk +38 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/minimal_chart_ru.xml View 2 1 chunk +38 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/minimal_chart_sl.xml View 2 1 chunk +38 lines, -0 lines 0 comments Download
M modules/sale_advance_payment/sale.py View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M modules/sale_advance_payment/tests/scenario_advance_payment.rst View 1 2 2 chunks +3 lines, -13 lines 0 comments Download
M modules/sale_advance_payment/tests/tools.py View 2 2 chunks +16 lines, -0 lines 0 comments Download
M modules/sale_advance_payment/tryton.cfg View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
A modules/sale_advance_payment/view/account_type_form.xml View 2 1 chunk +9 lines, -0 lines 0 comments Download
M modules/sale_credit_limit/tests/test_sale_credit_limit.py View 2 1 chunk +2 lines, -2 lines 0 comments Download
M modules/stock_supply/tests/test_stock_supply.py View 2 1 chunk +2 lines, -2 lines 0 comments Download
M modules/stock_supply_day/tests/test_stock_supply_day.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
ced
3 weeks, 4 days ago (2018-12-27 17:57:50 UTC) #1
reviewbot
https://codereview.tryton.org/68401002/diff/1/modules/analytic_account/account.py#newcode205 modules/analytic_account/account.py:205: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
3 weeks, 4 days ago (2018-12-27 18:08:56 UTC) #2
ced
1 week, 6 days ago (2019-01-08 18:13:30 UTC) #3
reviewbot
patch is not applicable URL: https://codereview.tryton.org/68401002
1 week, 6 days ago (2019-01-08 18:42:37 UTC) #4
ced
1 week, 4 days ago (2019-01-10 19:27:43 UTC) #5
reviewbot
patch is not applicable URL: https://codereview.tryton.org/68401002
1 week, 4 days ago (2019-01-10 19:43:46 UTC) #6
dave
5 days, 14 hours ago (2019-01-16 11:40:01 UTC) #7
https://codereview.tryton.org/68401002/diff/30001/modules/account/account.py
File modules/account/account.py (right):

https://codereview.tryton.org/68401002/diff/30001/modules/account/account.py#...
modules/account/account.py:51: receivable = fields.Boolean(
In the Type class below, should these fields be readonly unless
template_override is set to True?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766