Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(780)

Issue 68491002: sale_opportunity: Remove required on description

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by mrichez
Modified:
1 week, 1 day ago
Reviewers:
reviewbot
Visibility:
Public.

Description

issue8092 Description field is used when creating the sale but not required for this model. So required constraint seems unnecessary.

Patch Set 1 #

Patch Set 2 : Add removing sql constraint #

Patch Set 3 : Add CHANGELOG #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M CHANGELOG View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M opportunity.py View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 5
mrichez
1 week, 1 day ago (2019-02-08 08:14:06 UTC) #1
mrichez
Add removing sql constraint
1 week, 1 day ago (2019-02-08 08:25:28 UTC) #2
reviewbot
https://codereview.tryton.org/68491002/diff/20001/opportunity.py#newcode594 opportunity.py:594: E127 continuation line over-indented for visual indent https://codereview.tryton.org/68491002/diff/20001/opportunity.py#newcode596 opportunity.py:596: E127 continuation line over-indented ...
1 week, 1 day ago (2019-02-08 08:34:41 UTC) #3
mrichez
Add CHANGELOG
1 week, 1 day ago (2019-02-08 08:46:20 UTC) #4
reviewbot
1 week, 1 day ago (2019-02-08 09:12:15 UTC) #5
https://codereview.tryton.org/68491002/diff/40001/opportunity.py#newcode594
opportunity.py:594:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/68491002/diff/40001/opportunity.py#newcode596
opportunity.py:596:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/68491002/diff/40001/opportunity.py#newcode598
opportunity.py:598:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/68491002/diff/40001/opportunity.py#newcode601
opportunity.py:601:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/68491002/diff/40001/opportunity.py#newcode604
opportunity.py:604:
E127 continuation line over-indented for visual indent

URL: https://codereview.tryton.org/68491002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766