Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 68491002: sale_opportunity: Remove required on description (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by mrichez
Modified:
3 weeks, 6 days ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Description field is used when creating the sale but not required for this model. So required constraint seems unnecessary. issue8092

Patch Set 1 #

Patch Set 2 : Add removing sql constraint #

Patch Set 3 : Add CHANGELOG #

Total comments: 2

Patch Set 4 : Move migration code following remark #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M CHANGELOG View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M opportunity.py View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 12
mrichez
2 months, 1 week ago (2019-02-08 08:14:06 UTC) #1
mrichez
Add removing sql constraint
2 months, 1 week ago (2019-02-08 08:25:28 UTC) #2
reviewbot
https://codereview.tryton.org/68491002/diff/20001/opportunity.py#newcode594 opportunity.py:594: E127 continuation line over-indented for visual indent https://codereview.tryton.org/68491002/diff/20001/opportunity.py#newcode596 opportunity.py:596: E127 continuation line over-indented ...
2 months, 1 week ago (2019-02-08 08:34:41 UTC) #3
mrichez
Add CHANGELOG
2 months, 1 week ago (2019-02-08 08:46:20 UTC) #4
reviewbot
https://codereview.tryton.org/68491002/diff/40001/opportunity.py#newcode594 opportunity.py:594: E127 continuation line over-indented for visual indent https://codereview.tryton.org/68491002/diff/40001/opportunity.py#newcode596 opportunity.py:596: E127 continuation line over-indented ...
2 months, 1 week ago (2019-02-08 09:12:15 UTC) #5
ced
LGTM
1 month, 1 week ago (2019-03-10 11:21:19 UTC) #6
ced
https://codereview.tryton.org/68491002/diff/40001/opportunity.py File opportunity.py (right): https://codereview.tryton.org/68491002/diff/40001/opportunity.py#newcode127 opportunity.py:127: table.not_null_action('description', action='remove') Better to put such migration after the ...
1 month, 1 week ago (2019-03-10 11:22:09 UTC) #7
mrichez
https://codereview.tryton.org/68491002/diff/40001/opportunity.py File opportunity.py (right): https://codereview.tryton.org/68491002/diff/40001/opportunity.py#newcode127 opportunity.py:127: table.not_null_action('description', action='remove') On 2019/03/10 11:22:09, ced wrote: > Better ...
1 month, 1 week ago (2019-03-11 08:34:43 UTC) #8
mrichez
Move migration code following remark
1 month, 1 week ago (2019-03-11 08:35:53 UTC) #9
reviewbot
https://codereview.tryton.org/68491002/diff/281081002/opportunity.py#newcode594 opportunity.py:594: E127 continuation line over-indented for visual indent https://codereview.tryton.org/68491002/diff/281081002/opportunity.py#newcode596 opportunity.py:596: E127 continuation line over-indented ...
1 month, 1 week ago (2019-03-11 08:49:40 UTC) #10
ced
LGTM
3 weeks, 6 days ago (2019-03-22 10:10:49 UTC) #11
rietveld-bot_tryton.org
3 weeks, 6 days ago (2019-03-22 10:12:39 UTC) #12
New changeset 48ef9a0e4c97 by Maxime Richez in branch 'default':
Remove required on description
https://hg.tryton.org/modules/sale_opportunity/rev/48ef9a0e4c97
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766