Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 70461002: tryton-env: return a rejected promise when the icon name is invalid

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by nicoe
Modified:
1 week, 1 day ago
Reviewers:
reviewbot, ced, albert
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Throw an exception and fix calls that require checks #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M sao/src/common.js View 1 1 chunk +1 line, -1 line 0 comments Download
M sao/src/view/form.js View 1 1 chunk +6 lines, -4 lines 1 comment Download
M sao/src/view/tree.js View 1 1 chunk +12 lines, -10 lines 1 comment Download

Messages

Total messages: 6
nicoe
1 week, 6 days ago (2018-12-05 17:32:52 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/70461002
1 week, 6 days ago (2018-12-05 17:41:03 UTC) #2
albert
LGTM
1 week, 4 days ago (2018-12-07 12:48:53 UTC) #3
nicoe
Throw an exception and fix calls that require checks
1 week, 4 days ago (2018-12-07 17:12:46 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/70461002
1 week, 4 days ago (2018-12-07 17:46:03 UTC) #5
ced
1 week, 1 day ago (2018-12-10 21:31:00 UTC) #6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766