Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 70491002: sale_opportunity: Add link between opportunities and projects

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by pokoli
Modified:
2 months ago
Reviewers:
dave, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix dave's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -4 lines) Patch
M CHANGELOG View 1 1 chunk +3 lines, -0 lines 0 comments Download
M __init__.py View 2 chunks +4 lines, -0 lines 0 comments Download
M opportunity.py View 5 chunks +34 lines, -2 lines 0 comments Download
M opportunity.xml View 2 chunks +12 lines, -1 line 0 comments Download
M setup.py View 1 chunk +4 lines, -1 line 0 comments Download
A tests/scenario_sale_opportunity_project.rst View 1 chunk +111 lines, -0 lines 0 comments Download
M tests/test_sale_opportunity.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tryton.cfg View 1 chunk +3 lines, -0 lines 0 comments Download
M view/opportunity_form.xml View 1 chunk +1 line, -0 lines 0 comments Download
A view/opportunity_form_project.xml View 1 chunk +10 lines, -0 lines 0 comments Download
A work.py View 1 chunk +19 lines, -0 lines 0 comments Download
A work.xml View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5
pokoli
2 months, 1 week ago (2019-01-11 15:22:26 UTC) #1
reviewbot
https://codereview.tryton.org/70491002/diff/1/__init__.py#newcode5 __init__.py:5: F403 'from opportunity import *' used; unable to detect undefined names https://codereview.tryton.org/70491002/diff/1/__init__.py#newcode6 __init__.py:6: ...
2 months, 1 week ago (2019-01-11 15:44:07 UTC) #2
dave
https://codereview.tryton.org/70491002/diff/1/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/70491002/diff/1/CHANGELOG#newcode2 CHANGELOG:2: * Allow to mark converted opportunities as won or ...
2 months, 1 week ago (2019-01-14 21:01:38 UTC) #3
pokoli
Fix dave's comment
2 months ago (2019-01-21 15:39:52 UTC) #4
reviewbot
2 months ago (2019-01-21 16:05:30 UTC) #5
https://codereview.tryton.org/70491002/diff/20001/__init__.py#newcode5
__init__.py:5:
F403 'from opportunity import *' used; unable to detect undefined names

https://codereview.tryton.org/70491002/diff/20001/__init__.py#newcode6
__init__.py:6:
F403 'from configuration import *' used; unable to detect undefined names

https://codereview.tryton.org/70491002/diff/20001/__init__.py#newcode7
__init__.py:7:
F403 'from sale import *' used; unable to detect undefined names

https://codereview.tryton.org/70491002/diff/20001/__init__.py#newcode8
__init__.py:8:
F403 'from party import *' used; unable to detect undefined names

https://codereview.tryton.org/70491002/diff/20001/__init__.py#newcode9
__init__.py:9:
F403 'from account import *' used; unable to detect undefined names

https://codereview.tryton.org/70491002/diff/20001/__init__.py#newcode10
__init__.py:10:
F403 'from product import *' used; unable to detect undefined names

https://codereview.tryton.org/70491002/diff/20001/__init__.py#newcode11
__init__.py:11:
F403 'from company import *' used; unable to detect undefined names

https://codereview.tryton.org/70491002/diff/20001/opportunity.py#newcode623
opportunity.py:623:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/70491002/diff/20001/opportunity.py#newcode625
opportunity.py:625:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/70491002/diff/20001/opportunity.py#newcode627
opportunity.py:627:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/70491002/diff/20001/opportunity.py#newcode630
opportunity.py:630:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/70491002/diff/20001/opportunity.py#newcode633
opportunity.py:633:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/70491002/diff/20001/setup.py#newcode87
setup.py:87:
E501 line too long (85 > 79 characters)

URL: https://codereview.tryton.org/70491002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766