Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(840)

Issue 70531002: tryton-env: Remove mandatory on analytic roots

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 2 days ago by ced
Modified:
3 days ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

Having required field managed by user breaks automated workflows. issue7605

Patch Set 1 #

Patch Set 2 : Flake8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -211 lines) Patch
M modules/analytic_account/CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M modules/analytic_account/account.py View 1 7 chunks +2 lines, -52 lines 0 comments Download
M modules/analytic_account/exceptions.py View 1 1 chunk +0 lines, -4 lines 0 comments Download
M modules/analytic_account/message.xml View 1 chunk +0 lines, -3 lines 0 comments Download
M modules/analytic_account/view/account_form.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M modules/analytic_invoice/tests/scenario_analytic_invoice.rst View 6 chunks +2 lines, -31 lines 0 comments Download
M modules/analytic_purchase/__init__.py View 1 chunk +3 lines, -4 lines 0 comments Download
M modules/analytic_purchase/purchase.py View 1 2 chunks +0 lines, -44 lines 0 comments Download
M modules/analytic_purchase/tests/scenario_analytic_purchase.rst View 5 chunks +4 lines, -46 lines 0 comments Download
M modules/analytic_sale/tests/scenario_analytic_sale.rst View 6 chunks +5 lines, -25 lines 0 comments Download

Messages

Total messages: 5
ced
1 week, 2 days ago (2019-02-06 22:27:03 UTC) #1
reviewbot
https://codereview.tryton.org/70531002/diff/1/modules/analytic_purchase/purchase.py#newcode3 modules/analytic_purchase/purchase.py:3: F401 'gettext' imported but unused https://codereview.tryton.org/70531002/diff/1/modules/analytic_purchase/purchase.py#newcode9 modules/analytic_purchase/purchase.py:9: F401 'PurchaseQuotationError' imported but unused https://codereview.tryton.org/70531002/diff/1/modules/analytic_account/account.py#newcode19 ...
1 week, 2 days ago (2019-02-06 22:37:57 UTC) #2
ced
1 week, 2 days ago (2019-02-06 22:59:05 UTC) #3
reviewbot
https://codereview.tryton.org/70531002/diff/20001/modules/analytic_account/account.py#newcode199 modules/analytic_account/account.py:199: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
1 week, 2 days ago (2019-02-06 23:18:45 UTC) #4
pokoli
3 days ago (2019-02-13 19:49:08 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766