Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 70531002: tryton-env: Remove mandatory on analytic roots (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month, 4 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Having required field managed by user breaks automated workflows. issue7605

Patch Set 1 #

Patch Set 2 : Flake8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -211 lines) Patch
M modules/analytic_account/CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M modules/analytic_account/account.py View 1 7 chunks +2 lines, -52 lines 0 comments Download
M modules/analytic_account/exceptions.py View 1 1 chunk +0 lines, -4 lines 0 comments Download
M modules/analytic_account/message.xml View 1 chunk +0 lines, -3 lines 0 comments Download
M modules/analytic_account/view/account_form.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M modules/analytic_invoice/tests/scenario_analytic_invoice.rst View 6 chunks +2 lines, -31 lines 0 comments Download
M modules/analytic_purchase/__init__.py View 1 chunk +3 lines, -4 lines 0 comments Download
M modules/analytic_purchase/purchase.py View 1 2 chunks +0 lines, -44 lines 0 comments Download
M modules/analytic_purchase/tests/scenario_analytic_purchase.rst View 5 chunks +4 lines, -46 lines 0 comments Download
M modules/analytic_sale/tests/scenario_analytic_sale.rst View 6 chunks +5 lines, -25 lines 0 comments Download

Messages

Total messages: 10
ced
2 months, 1 week ago (2019-02-06 22:27:03 UTC) #1
reviewbot
https://codereview.tryton.org/70531002/diff/1/modules/analytic_purchase/purchase.py#newcode3 modules/analytic_purchase/purchase.py:3: F401 'gettext' imported but unused https://codereview.tryton.org/70531002/diff/1/modules/analytic_purchase/purchase.py#newcode9 modules/analytic_purchase/purchase.py:9: F401 'PurchaseQuotationError' imported but unused https://codereview.tryton.org/70531002/diff/1/modules/analytic_account/account.py#newcode19 ...
2 months, 1 week ago (2019-02-06 22:37:57 UTC) #2
ced
2 months, 1 week ago (2019-02-06 22:59:05 UTC) #3
reviewbot
https://codereview.tryton.org/70531002/diff/20001/modules/analytic_account/account.py#newcode199 modules/analytic_account/account.py:199: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
2 months, 1 week ago (2019-02-06 23:18:45 UTC) #4
pokoli
LGTM
2 months ago (2019-02-13 19:49:08 UTC) #5
rietveld-bot_tryton.org
New changeset 69d28a7108fe by Cédric Krier in branch 'default': Remove mandatory on analytic roots https://hg.tryton.org/modules/analytic_account/rev/69d28a7108fe
1 month, 4 weeks ago (2019-02-18 17:40:13 UTC) #6
rietveld-bot_tryton.org
New changeset 9c877cee41e9 by Cédric Krier in branch 'default': Remove mandatory on analytic roots https://hg.tryton.org/modules/analytic_invoice/rev/9c877cee41e9
1 month, 4 weeks ago (2019-02-18 17:40:19 UTC) #7
rietveld-bot_tryton.org
New changeset f160c38addd9 by Cédric Krier in branch 'default': Remove mandatory on analytic roots https://hg.tryton.org/modules/analytic_purchase/rev/f160c38addd9
1 month, 4 weeks ago (2019-02-18 17:40:24 UTC) #8
rietveld-bot_tryton.org
New changeset be01a2ddcb79 by Cédric Krier in branch 'default': Remove mandatory on analytic roots https://hg.tryton.org/modules/analytic_sale/rev/be01a2ddcb79
1 month, 4 weeks ago (2019-02-18 17:40:27 UTC) #9
rietveld-bot_tryton.org
1 month, 4 weeks ago (2019-02-18 17:40:35 UTC) #10
New changeset 2e0eef4f87cf by Cédric Krier in branch 'default':
Remove mandatory on analytic roots
https://hg.tryton.org/tryton-env/rev/2e0eef4f87cf
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766