Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 7081002: account_sepa_message: Initial commit

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by nicoe
Modified:
2 years, 3 months ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

This module is the base module of SEPA messaging. issue4658

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add README/setup.py/etc files #

Total comments: 3

Patch Set 3 : update to tip #

Patch Set 4 : pep8 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1293 lines, -0 lines) Patch
A .drone.yml View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
A COPYRIGHT View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A INSTALL View 1 1 chunk +33 lines, -0 lines 0 comments Download
A LICENSE View 1 1 chunk +674 lines, -0 lines 0 comments Download
A README View 1 1 chunk +35 lines, -0 lines 0 comments Download
A __init__.py View 1 chunk +14 lines, -0 lines 0 comments Download
A message.py View 1 2 1 chunk +193 lines, -0 lines 2 comments Download
A message.xml View 1 chunk +106 lines, -0 lines 0 comments Download
A setup.py View 1 2 1 chunk +128 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A tests/test_account_sepa_message.py View 1 chunk +18 lines, -0 lines 0 comments Download
A tox.ini View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A tryton.cfg View 1 chunk +9 lines, -0 lines 0 comments Download
A view/message_form.xml View 1 chunk +23 lines, -0 lines 0 comments Download
A view/message_list.xml View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8
reviewbot
http://codereview.tryton.org/7081002/diff/1/__init__.py File __init__.py (right): http://codereview.tryton.org/7081002/diff/1/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
3 years, 8 months ago (2015-03-31 16:00:18 UTC) #1
reviewbot
http://codereview.tryton.org/7081002/diff/20001/__init__.py File __init__.py (right): http://codereview.tryton.org/7081002/diff/20001/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
3 years, 8 months ago (2015-03-31 16:20:20 UTC) #2
nicoe
update to tip
2 years, 6 months ago (2016-06-01 13:24:29 UTC) #3
reviewbot
https://codereview.tryton.org/7081002/diff/40001/__init__.py#newcode5 __init__.py:5: F403 'from message import *' used; unable to detect undefined names https://codereview.tryton.org/7081002/diff/40001/tests/__init__.py#newcode7 tests/__init__.py:7: ...
2 years, 6 months ago (2016-06-01 13:30:39 UTC) #4
nicoe
pep8
2 years, 6 months ago (2016-06-01 13:52:20 UTC) #5
reviewbot
https://codereview.tryton.org/7081002/diff/60001/__init__.py#newcode5 __init__.py:5: F403 'from message import *' used; unable to detect undefined names URL: https://codereview.tryton.org/7081002
2 years, 6 months ago (2016-06-01 14:00:50 UTC) #6
pokoli
https://tryton-rietveld.appspot.com/7081002/diff/60001/message.py File message.py (right): https://tryton-rietveld.appspot.com/7081002/diff/60001/message.py#newcode133 message.py:133: def do_wizard(cls, messages): why not using a button directly?
2 years, 3 months ago (2016-09-14 15:34:42 UTC) #7
nicoe
2 years, 3 months ago (2016-09-14 15:47:47 UTC) #8
https://tryton-rietveld.appspot.com/7081002/diff/60001/message.py
File message.py (right):

https://tryton-rietveld.appspot.com/7081002/diff/60001/message.py#newcode133
message.py:133: def do_wizard(cls, messages):
On 2016/09/14 15:34:42, pokoli wrote:
> why not using a button directly?

I don't remember exactly in fact.
Probably in order to allow to override the wizard to add additional information
or something.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766