Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 72311002: account_fr: Skip line with debit and credit equals to zero in FEC (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by ced
Modified:
4 days, 16 hours ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Set filter on search domain as PG will any way do a sequence scan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M account.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/scenario_fec.rst View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6
ced
1 week, 3 days ago (2018-09-11 10:30:39 UTC) #1
ced
Set filter on search domain as PG will any way do a sequence scan
1 week, 3 days ago (2018-09-11 10:36:35 UTC) #2
reviewbot
https://codereview.tryton.org/72311002/diff/20001/account.py#newcode69 account.py:69: E501 line too long (82 > 79 characters) URL: https://codereview.tryton.org/72311002
1 week, 3 days ago (2018-09-11 11:02:07 UTC) #3
pokoli
LGTM
1 week, 2 days ago (2018-09-12 13:49:43 UTC) #4
rietveld-bot_tryton.org
New changeset 5a33f04ac673 by Cédric Krier in branch 'default': Skip line with debit and credit ...
4 days, 16 hours ago (2018-09-17 15:45:16 UTC) #5
rietveld-bot_tryton.org
4 days, 16 hours ago (2018-09-17 15:45:21 UTC) #6
New changeset 8c5ee02ed70a by Cédric Krier in branch 'default':
Skip line with debit and credit equals to zero in FEC
https://hg.tryton.org/tryton-env/rev/8c5ee02ed70a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766