Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 72371002: tryton-env: Include all identifier from python-stdnum

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by ced
Modified:
1 week, 4 days ago
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove Spanish subset of vat #

Patch Set 3 : Re-add spanish subset but define as tax identifer, add eu vat and US tin as tax identifier #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -31 lines) Patch
M modules/account_invoice/invoice.py View 2 chunks +4 lines, -4 lines 0 comments Download
M modules/party/CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M modules/party/party.py View 1 2 10 chunks +147 lines, -27 lines 4 comments Download

Messages

Total messages: 12
ced
1 week, 5 days ago (2018-12-06 18:20:52 UTC) #1
pokoli
https://codereview.tryton.org/72371002/diff/1/modules/party/party.py File modules/party/party.py (right): https://codereview.tryton.org/72371002/diff/1/modules/party/party.py#newcode347 modules/party/party.py:347: ('es_cif', "Spanish Company Tax Number"), does it really make ...
1 week, 5 days ago (2018-12-06 18:38:15 UTC) #2
reviewbot
https://codereview.tryton.org/72371002/diff/1/modules/account_invoice/invoice.py#newcode606 modules/account_invoice/invoice.py:606: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/72371002
1 week, 5 days ago (2018-12-06 18:47:38 UTC) #3
ced
1 week, 5 days ago (2018-12-06 20:30:17 UTC) #4
reviewbot
https://codereview.tryton.org/72371002/diff/20001/modules/account_invoice/invoice.py#newcode606 modules/account_invoice/invoice.py:606: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/72371002
1 week, 5 days ago (2018-12-06 20:39:35 UTC) #5
timitos3000
https://codereview.tryton.org/72371002/diff/1/modules/party/party.py File modules/party/party.py (right): https://codereview.tryton.org/72371002/diff/1/modules/party/party.py#newcode347 modules/party/party.py:347: ('es_cif', "Spanish Company Tax Number"), On 2018/12/06 18:38:14, pokoli ...
1 week, 4 days ago (2018-12-07 08:25:25 UTC) #6
ced
1 week, 4 days ago (2018-12-07 09:53:14 UTC) #7
reviewbot
https://codereview.tryton.org/72371002/diff/40001/modules/account_invoice/invoice.py#newcode606 modules/account_invoice/invoice.py:606: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/72371002
1 week, 4 days ago (2018-12-07 10:11:29 UTC) #8
pokoli
https://codereview.tryton.org/72371002/diff/1/modules/party/party.py File modules/party/party.py (right): https://codereview.tryton.org/72371002/diff/1/modules/party/party.py#newcode347 modules/party/party.py:347: ('es_cif', "Spanish Company Tax Number"), On 2018/12/07 08:25:25, timitos3000 ...
1 week, 4 days ago (2018-12-07 12:12:18 UTC) #9
pokoli
https://codereview.tryton.org/72371002/diff/40001/modules/party/party.py File modules/party/party.py (right): https://codereview.tryton.org/72371002/diff/40001/modules/party/party.py#newcode360 modules/party/party.py:360: ('es_cif', "Spanish Company Tax"), Don't know the sorce of ...
1 week, 4 days ago (2018-12-07 12:27:58 UTC) #10
ced
https://codereview.tryton.org/72371002/diff/40001/modules/party/party.py File modules/party/party.py (right): https://codereview.tryton.org/72371002/diff/40001/modules/party/party.py#newcode360 modules/party/party.py:360: ('es_cif', "Spanish Company Tax"), On 2018/12/07 12:27:58, pokoli wrote: ...
1 week, 4 days ago (2018-12-07 12:53:06 UTC) #11
timitos3000
1 week, 4 days ago (2018-12-07 13:20:51 UTC) #12
https://codereview.tryton.org/72371002/diff/1/modules/party/party.py
File modules/party/party.py (right):

https://codereview.tryton.org/72371002/diff/1/modules/party/party.py#newcode347
modules/party/party.py:347: ('es_cif', "Spanish Company Tax Number"),
On 2018/12/07 12:12:18, pokoli wrote:
> On 2018/12/07 08:25:25, timitos3000 wrote:
> > On 2018/12/06 18:38:14, pokoli wrote:
> > > does it really make sense to include es_cif, es_dni, es_nie? They are a
> subset
> > > of the eu_vat type
> > > 
> > > Main main concern here is that the user will pick 'es_cif' for an spanish
> > > company expecting this number to be used as tax identifier but it won't be
> as
> > > only eu_vat is selected for tax identifiers. 
> > > 
> > > I suspect the same happens with other European countries. 
> > 
> > But eu_vat is a code that only companies can get. So why is es_dni a subset
of
> > eu_vat as the naming seems to show that this is a code that can be held by
> > persons that do not have a company?
> 
> In spain the eu_vat for companies is the es_cif code with the 'ES' prefix. 
> 
> For self-employees the es_dni (or es_nie if the person is not born in SPain)
is
> used instead of the es_cif. 
> 
> If a spanish user introduced the es_cif it will expect to use this identifier
as
> tax_identifier (and the same for es_dni and es_nie). 
> 
> How do you compute the eu_vat in germany? Is a different number from the
German
> Tax Number? 

In Germany there is de_stnr, de_idnr and de_vat. de_vat is identically to
eu_vat. de_stnr and de_idnr are completely different from de_vat/eu_vat. de_vat
und eu_vat identify a or a person for VAT taxation. Not everyone does have on.
Every natural person does have an de_idnr. Some natural persons and every
company do have a de_stnr. in the long run de_stnr will be obsolete. de_idnr
seams to be based on an eu wide standard. The short name is TIN. But i only
found a german entry in wikipedia[1] that says that it will also be implemented
in other european countries.

[1] https://de.wikipedia.org/wiki/Steuerliche_Identifikationsnummer
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766