Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(771)

Issue 72371002: tryton-env: Include all identifier from python-stdnum

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month ago
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove Spanish subset of vat #

Patch Set 3 : Re-add spanish subset but define as tax identifer, add eu vat and US tin as tax identifier #

Total comments: 4

Patch Set 4 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -31 lines) Patch
M modules/account_invoice/invoice.py View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M modules/party/CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M modules/party/message.xml View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M modules/party/party.py View 1 2 3 9 chunks +147 lines, -25 lines 0 comments Download

Messages

Total messages: 15
ced
2 months, 1 week ago (2018-12-06 18:20:52 UTC) #1
pokoli
https://codereview.tryton.org/72371002/diff/1/modules/party/party.py File modules/party/party.py (right): https://codereview.tryton.org/72371002/diff/1/modules/party/party.py#newcode347 modules/party/party.py:347: ('es_cif', "Spanish Company Tax Number"), does it really make ...
2 months, 1 week ago (2018-12-06 18:38:15 UTC) #2
reviewbot
https://codereview.tryton.org/72371002/diff/1/modules/account_invoice/invoice.py#newcode606 modules/account_invoice/invoice.py:606: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/72371002
2 months, 1 week ago (2018-12-06 18:47:38 UTC) #3
ced
2 months, 1 week ago (2018-12-06 20:30:17 UTC) #4
reviewbot
https://codereview.tryton.org/72371002/diff/20001/modules/account_invoice/invoice.py#newcode606 modules/account_invoice/invoice.py:606: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/72371002
2 months, 1 week ago (2018-12-06 20:39:35 UTC) #5
timitos3000
https://codereview.tryton.org/72371002/diff/1/modules/party/party.py File modules/party/party.py (right): https://codereview.tryton.org/72371002/diff/1/modules/party/party.py#newcode347 modules/party/party.py:347: ('es_cif', "Spanish Company Tax Number"), On 2018/12/06 18:38:14, pokoli ...
2 months, 1 week ago (2018-12-07 08:25:25 UTC) #6
ced
2 months, 1 week ago (2018-12-07 09:53:14 UTC) #7
reviewbot
https://codereview.tryton.org/72371002/diff/40001/modules/account_invoice/invoice.py#newcode606 modules/account_invoice/invoice.py:606: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/72371002
2 months, 1 week ago (2018-12-07 10:11:29 UTC) #8
pokoli
https://codereview.tryton.org/72371002/diff/1/modules/party/party.py File modules/party/party.py (right): https://codereview.tryton.org/72371002/diff/1/modules/party/party.py#newcode347 modules/party/party.py:347: ('es_cif', "Spanish Company Tax Number"), On 2018/12/07 08:25:25, timitos3000 ...
2 months, 1 week ago (2018-12-07 12:12:18 UTC) #9
pokoli
https://codereview.tryton.org/72371002/diff/40001/modules/party/party.py File modules/party/party.py (right): https://codereview.tryton.org/72371002/diff/40001/modules/party/party.py#newcode360 modules/party/party.py:360: ('es_cif', "Spanish Company Tax"), Don't know the sorce of ...
2 months, 1 week ago (2018-12-07 12:27:58 UTC) #10
ced
https://codereview.tryton.org/72371002/diff/40001/modules/party/party.py File modules/party/party.py (right): https://codereview.tryton.org/72371002/diff/40001/modules/party/party.py#newcode360 modules/party/party.py:360: ('es_cif', "Spanish Company Tax"), On 2018/12/07 12:27:58, pokoli wrote: ...
2 months, 1 week ago (2018-12-07 12:53:06 UTC) #11
timitos3000
https://codereview.tryton.org/72371002/diff/1/modules/party/party.py File modules/party/party.py (right): https://codereview.tryton.org/72371002/diff/1/modules/party/party.py#newcode347 modules/party/party.py:347: ('es_cif', "Spanish Company Tax Number"), On 2018/12/07 12:12:18, pokoli ...
2 months, 1 week ago (2018-12-07 13:20:51 UTC) #12
ced
1 month, 2 weeks ago (2018-12-29 14:38:55 UTC) #13
reviewbot
https://codereview.tryton.org/72371002/diff/60001/modules/account_invoice/invoice.py#newcode580 modules/account_invoice/invoice.py:580: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/72371002
1 month, 2 weeks ago (2018-12-29 15:17:44 UTC) #14
pokoli
1 month ago (2019-01-11 18:20:18 UTC) #15
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766