Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 74391002: account: Add test for update chart from template (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by pokoli
Modified:
4 months, 3 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Rename test into check and asset before checking full chart #

Patch Set 3 : Explicity test that new accounts and taxes are created #

Total comments: 11

Patch Set 4 : Improve variable naming #

Total comments: 4

Patch Set 5 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -8 lines) Patch
M tests/test_account.py View 1 2 3 4 2 chunks +158 lines, -8 lines 0 comments Download

Messages

Total messages: 21
pokoli
6 months ago (2018-10-20 16:53:22 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/74391002
6 months ago (2018-10-20 16:54:48 UTC) #2
ced
https://codereview.tryton.org/74391002/diff/1/tests/test_account.py File tests/test_account.py (right): https://codereview.tryton.org/74391002/diff/1/tests/test_account.py#newcode1090 tests/test_account.py:1090: def test(): I think it will be named check. ...
5 months, 4 weeks ago (2018-10-21 08:49:28 UTC) #3
pokoli
Rename test into check and asset before checking full chart
5 months, 4 weeks ago (2018-10-22 09:27:48 UTC) #4
pokoli
https://codereview.tryton.org/74391002/diff/1/tests/test_account.py File tests/test_account.py (right): https://codereview.tryton.org/74391002/diff/1/tests/test_account.py#newcode1090 tests/test_account.py:1090: def test(): On 2018/10/21 08:49:28, ced wrote: > I ...
5 months, 4 weeks ago (2018-10-22 09:28:10 UTC) #5
reviewbot
https://codereview.tryton.org/74391002/diff/20001/tests/test_account.py#newcode1156 tests/test_account.py:1156: E303 too many blank lines (2) URL: https://codereview.tryton.org/74391002
5 months, 4 weeks ago (2018-10-22 10:05:35 UTC) #6
ced
https://codereview.tryton.org/74391002/diff/1/tests/test_account.py File tests/test_account.py (right): https://codereview.tryton.org/74391002/diff/1/tests/test_account.py#newcode1171 tests/test_account.py:1171: new_tax_account.save() On 2018/10/22 09:28:10, pokoli wrote: > On 2018/10/21 ...
5 months, 4 weeks ago (2018-10-22 11:18:54 UTC) #7
pokoli
Explicity test that new accounts and taxes are created
5 months, 3 weeks ago (2018-10-25 12:36:58 UTC) #8
pokoli
https://codereview.tryton.org/74391002/diff/1/tests/test_account.py File tests/test_account.py (right): https://codereview.tryton.org/74391002/diff/1/tests/test_account.py#newcode1171 tests/test_account.py:1171: new_tax_account.save() On 2018/10/22 11:18:53, ced wrote: > On 2018/10/22 ...
5 months, 3 weeks ago (2018-10-25 12:37:44 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/74391002
5 months, 3 weeks ago (2018-10-25 12:57:17 UTC) #10
ced
https://codereview.tryton.org/74391002/diff/40001/tests/test_account.py File tests/test_account.py (right): https://codereview.tryton.org/74391002/diff/40001/tests/test_account.py#newcode62 tests/test_account.py:62: }]) this does not break other modules that use ...
5 months, 3 weeks ago (2018-10-25 13:19:58 UTC) #11
pokoli
Improve variable naming
5 months, 3 weeks ago (2018-10-25 13:38:41 UTC) #12
pokoli
https://codereview.tryton.org/74391002/diff/40001/tests/test_account.py File tests/test_account.py (right): https://codereview.tryton.org/74391002/diff/40001/tests/test_account.py#newcode62 tests/test_account.py:62: }]) On 2018/10/25 13:19:58, ced wrote: > this does ...
5 months, 3 weeks ago (2018-10-25 13:38:48 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/74391002
5 months, 3 weeks ago (2018-10-25 14:04:07 UTC) #14
ced
https://codereview.tryton.org/74391002/diff/40001/tests/test_account.py File tests/test_account.py (right): https://codereview.tryton.org/74391002/diff/40001/tests/test_account.py#newcode62 tests/test_account.py:62: }]) On 2018/10/25 13:38:47, pokoli wrote: > On 2018/10/25 ...
5 months, 3 weeks ago (2018-10-25 14:15:01 UTC) #15
ced
https://codereview.tryton.org/74391002/diff/60001/tests/test_account.py File tests/test_account.py (right): https://codereview.tryton.org/74391002/diff/60001/tests/test_account.py#newcode1173 tests/test_account.py:1173: tax, = TaxTemplate.search([]) updated_tax https://codereview.tryton.org/74391002/diff/60001/tests/test_account.py#newcode1193 tests/test_account.py:1193: tax_code, = TaxCodeTemplate.search([('name', ...
5 months, 3 weeks ago (2018-10-26 08:21:16 UTC) #16
pokoli
Fix comments
5 months, 3 weeks ago (2018-10-26 08:50:54 UTC) #17
reviewbot
flake8 OK URL: https://codereview.tryton.org/74391002
5 months, 3 weeks ago (2018-10-26 08:56:28 UTC) #18
ced
LGTM
5 months, 3 weeks ago (2018-10-26 09:12:05 UTC) #19
rietveld-bot_tryton.org
New changeset 4f40f667173d by Sergi Almacellas Abellana in branch 'default': Add test for update chart ...
4 months, 3 weeks ago (2018-11-27 11:53:02 UTC) #20
rietveld-bot_tryton.org
4 months, 3 weeks ago (2018-11-27 11:53:10 UTC) #21
New changeset 4d83a26311e6 by Sergi Almacellas Abellana in branch 'default':
Add test for update chart from template
https://hg.tryton.org/tryton-env/rev/4d83a26311e6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766