Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2150)

Issue 74461002: stock_split: Call the copy method with a list of instances instead of ids (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by oqueralto
Modified:
2 months, 2 weeks ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M stock.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
oqueralto
3 months ago (2019-02-19 06:13:55 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/74461002
3 months ago (2019-02-19 06:39:47 UTC) #2
pokoli
Thank you so much for the patch. There are some minor issues that should be ...
3 months ago (2019-02-19 07:56:21 UTC) #3
oqueralto
On 2019/02/19 07:56:21, pokoli wrote: > Thank you so much for the patch. There are ...
3 months ago (2019-02-19 08:13:58 UTC) #4
pokoli
On 2019/02/19 08:13:58, oqueralto wrote: > On 2019/02/19 07:56:21, pokoli wrote: > > Thank you ...
3 months ago (2019-02-19 08:24:22 UTC) #5
oqueralto
On 2019/02/19 08:24:22, pokoli wrote: > You should update the values for this review. It ...
3 months ago (2019-02-19 08:32:37 UTC) #6
ced
LGTM (I have simplified the subject).
2 months, 3 weeks ago (2019-02-25 13:30:53 UTC) #7
rietveld-bot_tryton.org
New changeset 45fe4b3d9e2a by Òscar Queraltó in branch 'default': Call the copy method with a ...
2 months, 3 weeks ago (2019-02-25 18:31:02 UTC) #8
rietveld-bot_tryton.org
2 months, 2 weeks ago (2019-03-06 23:05:59 UTC) #9
New changeset e61abccf6136 by Òscar Queraltó in branch '5.0':
Call the copy method with a list of instances instead of ids
https://hg.tryton.org/modules/stock_split/rev/e61abccf6136


New changeset ebb7a431928a by Òscar Queraltó in branch '4.8':
Call the copy method with a list of instances instead of ids
https://hg.tryton.org/modules/stock_split/rev/ebb7a431928a


New changeset 4d3c88697079 by Òscar Queraltó in branch '4.6':
Call the copy method with a list of instances instead of ids
https://hg.tryton.org/modules/stock_split/rev/4d3c88697079
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766