Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Recent Closed Issues

1 - 20 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
45801003	tryton-env: Use subproject alias and include proteus in readthedocs (Closed)	ced	rietveld-bot, reviewbot		17 hours, 55 minutes
50611002	tryton: Avoid to use self from upper scope in callback (Closed)	ced	reviewbot		1 week, 2 days
64471002	trytond: Ensure to rollback and clean cache on exception (Closed)	ced	pokoli, rietveld-bot, reviewbot		1 week, 3 days
68331002	account: Base journal cash report on account kind receivable and payable (Closed)	ced	pokoli, rietveld-bot, reviewbot		1 week, 3 days
56461002	account: Make writeoff required in ReconcileLinesWriteOff (Closed)	caf	rietveld-bot, ced, reviewbot		1 week, 3 days
47731002	account: Do not fail in party_required test if account is None in _get_writeoff_move (Closed)	ced	pokoli, rietveld-bot, reviewbot		1 week, 3 days
49651002	account_payment_sepa: Add party identifiers on check_code depends (Closed)	pokoli	rietveld-bot, ced, reviewbot		1 week, 3 days
68361002	sale_price_list: Ignore context uom if it is from different category than the product one (Closed)	pokoli	rietveld-bot, ced, reviewbot		1 week, 3 days
62361002	account_product: Do not raise empty taxes error on readonly transactions (Closed)	pokoli	rietveld-bot, ced, reviewbot	3	1 week, 3 days
46661002	product_price_list: Do not try to convert quantities from diferent uom categories (Closed)	pokoli	reviewbot		1 week, 4 days
50601002	account_product: Do not raise erros on readonly transactions when product has no taxes (Closed)	pokoli			2 weeks
45771002	trytond: Re-browse the filtered menus (Closed)	ced	rietveld-bot, reviewbot		2 weeks, 1 day
64461002	tryton: Use right new_order list when calling rows_reordered (Closed)	ced	rietveld-bot, reviewbot		2 weeks, 1 day
54411002	tryton-env: Fix tree_state (Closed)	ced	rietveld-bot, reviewbot		2 weeks, 1 day
45791002	tryton-env: Do not fail on One2Many with only tree mode (Closed)	ced	rietveld-bot, reviewbot		2 weeks, 1 day
70431002	sao: Do not use config key when setting Paparse settings (Closed)	pokoli	rietveld-bot, ced, reviewbot		2 weeks, 1 day
70441002	sale: Set cancel state for the transition of ShipmentOut.cancel (Closed)	ced	pokoli, rietveld-bot, nicoe, reviewbot		2 weeks, 1 day
52521003	currency: Require python-sql >= 0.9 (Closed)	ced	pokoli, rietveld-bot, reviewbot		2 weeks, 1 day
60411002	tryton-env: Add marketing_email (Closed)	pokoli	ced		2 weeks, 1 day
66461002	sao: Fix second reference tab and common compare if one array is undefined (Closed)	pierre.kunkel	reviewbot		2 weeks, 2 days

1 - 20 Older ›